Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The file includes/database/schema.inc contains several classes.
The first one in the file, abstract class DatabaseSchema, is missing a documentation block.
There's a doc block at the top of the file but it's for a @defgroup, not for the class.
Suggested block would be something like:
/**
* Base class for database schema definitions.
*/
So, we need a 3-line patch for Drupal 7.x to add something like this to the file.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2851665-3.patch | 442 bytes | tameeshb |
Comments
Comment #2
jhodgdonTypo in issue summary (file path).
Comment #3
tameeshb CreditAttribution: tameeshb at Google Summer of Code commentedUploaded patch, please review! :)
Comment #4
riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented@tameeshb,Thanks! for the patch it works well.
Comment #5
jhodgdonThank you! RTBC++
Comment #6
stefan.r CreditAttribution: stefan.r commentedComment #7
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedCommitted to 7.x - thanks!
Comment #9
riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented@David: Thanks for committing, but I guess you missed providing me RTBC credit for the efforts I putin. Can you please do the needful actions on it.
Have a great day ahead!
Comment #10
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedI actually missed crediting jhodgdon since I didn't notice that she was the one who came up with the suggested wording in the first place.
I'm crediting her now, and will go ahead and credit you this time also, Jigar.addweb.
Normally for very small issues like this one I limit the number of people I credit. Marking issues like this RTBC is certainly important! But if there's very little review or testing that needs to be done on a particular issue to mark it RTBC, I try to avoid diluting the credit system by adding too many credits. I do the same for my own contributions (for example https://www.drupal.org/node/2870289#comment-12113952). But I'll give you credit this time - thanks for your help on the issue.