Problem/Motivation

Since #2758897: Move rest module's "link manager" services to serialization module was committed in 8.3.x, this module should check for rest module in EntityReferenceRevisionsServiceProvider

CommentFileSizeAuthor
#7 2849136-7.patch1.21 KBtduong
#7 interdiff-2849136-4-7.txt306 bytestduong
#4 2849136-4.patch806 byteschr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Title: Add rest dependency » EntityReferenceRevisionsServiceProvider should chec for rest module
Issue summary: View changes
Status: Active » Closed (works as designed)
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Closed (works as designed) » Active
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review
FileSize
2849136-4.patch806 bytes

Here is a patch. Later, when 8.2 is outdated we could switch from rest.link_manager to serialization.link_manager and remove the rest check

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Title: EntityReferenceRevisionsServiceProvider should chec for rest module » EntityReferenceRevisionsServiceProvider should check for rest module

Status: Needs review » Needs work

The last submitted patch, 4: 2849136-4.patch, failed testing.

tduong’s picture

tduong CreditAttribution: tduong at MD Systems GmbH commented
Priority: Normal » Critical
Status: Needs work » Needs review
FileSize
interdiff-2849136-4-7.txt306 bytes
2849136-7.patch1.21 KB

Nice :) Also added an explicit rest dependency in the test that failed here: https://www.drupal.org/pift-ci-job/589216
Set as critical as tests are broken.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed, thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.