Make sure all 'configure' links are valid routes

Here is a test which will fail and prevent this from happening in the future. It also fails right now for both the workflows configure route and the content moderation one, so we have two to clean up here.

The test also includes a patch from #2848728: Contact module has an undeclared dependency on the user module.

From the test run:

Route "workflows.overview" does not exist.
Route "content_moderation.overview"

Making this a more general issue as the test in #4 tests all modules.

It looks like Content Moderation and Workflows are the only ones that need fixing, so we can fix both and provide the test as part of this issue.

I think this is more extension system.

Includes the fixes and a test only patch.

1. +++ b/core/tests/Drupal/KernelTests/Core/Extension/ModuleConfigureRouteTest.php
   @@ -0,0 +1,75 @@
   +      $this->enableModuleWithDependencies($module);
   ...
   +  /**
   +   * Enable a module with dependencies.
   +   *
   +   * @param string $module
   +   *   A module to enable.
   +   */
   +  protected function enableModuleWithDependencies($module) {
   +    $module_info = $this->moduleInfo[$module]->info;
   +    if (!empty($module_info['dependencies'])) {
   +      foreach ($module_info['dependencies'] as $dependency) {
   +        $this->enableModuleWithDependencies($dependency);
   +      }
   +    }
   +    if (!$this->container->get('module_handler')->moduleExists($module)) {
   +      $this->enableModules([$module]);
   +    }
   +  }
   

   I'm wondering whether why we cannot use the module installer directly ... here

2. +++ b/core/tests/Drupal/KernelTests/FileSystemModuleDiscoveryDataProviderTrait.php
   @@ -0,0 +1,30 @@
   +
   +/**
   + * A trait used in testing for providing a list of modules in a dataProvider.
   + */
   +trait FileSystemModuleDiscoveryDataProviderTrait {
   

   <3

3. +++ b/core/tests/Drupal/KernelTests/FileSystemModuleDiscoveryDataProviderTrait.php
   @@ -0,0 +1,30 @@
   +  /**
   +   * A data provider that lists every module in core.s
   

   Here is some quick typo

Great feedback. The module installer took about the same time locally as recursing through dependencies, so I think this is better.

Oh nice! Thank you for measuring it.

Committed and pushed a3c32eb to 8.4.x and dc7fd78 to 8.3.x. Thanks!

Really nice work! Love the new trait.