Problem/Motivation

Currently the order of workflow states and transitions can depend on the order they were added. When managing exported workflow configuration in version control this is annoying, as you can have unnecessary diffs when adding/removing workflow states or transitions.

Proposed resolution

Add deterministic sorting of workflow states and machine names by machine name.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 2845114-10.patch3.25 KBtstoeckler
#10 2845114-10-tests-only.patch2.5 KBtstoeckler
#10 2845114-6-10-interdiff.txt2.03 KBtstoeckler
#6 2845114-6.patch2.31 KBtstoeckler
#6 2845114-6--tests-only.patch1.57 KBtstoeckler
#6 2845114-3-6-interdiff.txt901 byteststoeckler
#3 2845114-3--test-only.patch984 bytesSam152
#3 2845114-3.patch1.71 KBSam152
#3 interdiff.txt984 bytesSam152
#2 2845114-2.patch762 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2845114-2.patch762 bytes

Here's an initial start.

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
FileSize
interdiff.txt984 bytes
2845114-3.patch1.71 KB
2845114-3--test-only.patch984 bytes

And a test.

Status: Needs review » Needs work

The last submitted patch, 3: 2845114-3--test-only.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

Works for me!

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Reviewed & tested by the community » Needs review
Issue tags: -Needs tests
FileSize
2845114-3-6-interdiff.txt901 bytes
2845114-6--tests-only.patch1.57 KB
2845114-6.patch2.31 KB

Adding a quick test for the transitions as well.

The last submitted patch, 6: 2845114-6--tests-only.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2845114-6.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Needs work » Needs review
FileSize
2845114-6-10-interdiff.txt2.03 KB
2845114-10-tests-only.patch2.5 KB
2845114-10.patch3.25 KB

Oops the test change caused some fallout. This should be better.

The last submitted patch, 10: 2845114-10-tests-only.patch, failed testing.

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Interdiff LGTM.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2845114-10.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2845114-10.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2845114-10.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 9a59b70 to 8.4.x and 4b70997 to 8.3.x. Thanks!

  • alexpott committed 9a59b70 on 8.4.x 
    Issue #2845114 by tstoeckler, Sam152: Add deterministic sorting of...

  • alexpott committed 4b70997 on 8.3.x 
    Issue #2845114 by tstoeckler, Sam152: Add deterministic sorting of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.