Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
Proposed resolution
Write EntityResourceTestBase subclass for the NodeType entity.
Remaining tasks
References
1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-2843777-4-6.txt | 770 bytes | shadcn |
#6 | entityresource_provide-2843777-6.patch | 8.04 KB | shadcn |
#4 | entityresource_provide-2843777-4.patch | 8.18 KB | shadcn |
Comments
Comment #3
shadcn CreditAttribution: shadcn at Chapter Three commentedWorking on this until #2853211: EntityResource::post() incorrectly assumes that every entity type has a canonical URL unblocks the other issues.
Comment #4
shadcn CreditAttribution: shadcn at Chapter Three commentedComment #5
Wim LeersInteresting, why all of them but not
POST
?Comment #6
shadcn CreditAttribution: shadcn at Chapter Three commentedThis was from
\Drupal\Tests\rest\Functional\EntityResource\Node\NodeResourceTestBase::getExpectedUnauthorizedAccessMessage
.Fixed it for
NodeTypeResourceTestBase
.Thanks @Wim Leers.
Comment #7
Wim LeersI just tried to fix it for
NodeResourceTestBase
too, and that causes fails. So that code is necessary forNodeResourceTestBase
. But #6 proves it's not necessary forNodeType
.So, this is good to go! Thanks!
Comment #8
alexpottCommitted and pushed 5222fbf to 8.4.x and 3ed4688 to 8.3.x. Thanks!