Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
Proposed resolution
Write EntityResourceTestBase subclass for the EntityFormDisplay entity.
Remaining tasks
References
1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.
Comment | File | Size | Author |
---|---|---|---|
#11 | 2843764-11.patch | 10.9 KB | Wim Leers |
Comments
Comment #3
dawehnerWhen you try to implement that you will run into: #2866666: Add proper access handlers for view and form displays in some form.
Comment #4
Wim LeersComment #5
shadcn CreditAttribution: shadcn at Chapter Three commentedWhat if we had access handlers like we did for the other entity types?
Comment #6
dawehnerIMHO we should do more than just view permissions. You should be able to post to those entity types as well.
Comment #7
Wim LeersWell… POSTing config entities won't work anyway until #2300677: JSON:API POST/PATCH support for fully validatable config entities. But yes, I agree we want to do #286666: tagadelic_node_get_terms($node) may try to return an undefined variable (nice issue ID btw :D) first.
Comment #8
Wim LeersComment #10
Wim Leers#2866666: Add proper access handlers for view and form displays landed, this is now unblocked!
Comment #11
Wim LeersStraight rebase of #5 — since #2866666: Add proper access handlers for view and form displays, only the tests remain.
On top of that straight rebase, only two changes were necessary:
status
field was added, so the expected config needed to be updated tooOther than that, this patch is identical to the one in #5 from more than 6 months ago — thanks @arshadcn!
Comment #12
Wim LeersActually, because #2866666: Add proper access handlers for view and form displays landed in 8.5 only, this also can be committed to 8.5 only.
Comment #14
Anonymous (not verified) CreditAttribution: Anonymous commented#11 perfect update! Fail in 8.4 as pointed in the #12 by Wim Leers.
Comment #15
catchCommitted 51f6344 and pushed to 8.5.x. Thanks!