Problem/Motivation

Please refer the problem/motivation section of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method

Proposed resolution

Write EntityResourceTestBase subclass for the ConfigurableLanguage entity.

Remaining tasks

References

1. Follow-up of #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method
2. Subtask of #2824572: Write EntityResourceTestBase subclasses for every other entity type.

CommentFileSizeAuthor
#5 interdiff.txt1.4 KBAnonymous (not verified)
#5 rest_configurable_language-2843761-5.patch9.2 KBAnonymous (not verified)
#3 rest_configurable_language-2843761-3.patch9.19 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review
FileSize
rest_configurable_language-2843761-3.patch9.19 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/rest/tests/src/Functional/EntityResource/ConfigurableLanguage/ConfigurableLanguageResourceTestBase.php
@@ -0,0 +1,80 @@
+      'id' => 'll',
+      'label' => 'Llama Language',

    :D 

  2. +++ b/core/modules/rest/tests/src/Functional/EntityResource/ConfigurableLanguage/ConfigurableLanguageResourceTestBase.php
@@ -0,0 +1,80 @@
+      'id' => $this->entity->id(),

    Can't we hardcode this? 

  3. +++ b/core/modules/rest/tests/src/Functional/EntityResource/ConfigurableLanguage/ConfigurableLanguageResourceTestBase.php
@@ -0,0 +1,80 @@
+  protected function getExpectedCacheContexts() {
+    return [
+      'languages:language_interface',
+      'url.site',
+      'user.permissions',
+    ];
+  }

    Let's call the parent method and add our additional expected cache context.

    So:

    return Cache::mergeContexts(parent::getExpectedCacheContexts(), ['languages:language_interface']);

As soon as those two nits are fixed, this is RTBC!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
rest_configurable_language-2843761-5.patch9.2 KB
interdiff.txt1.4 KB

Done, thanks!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 66c750c to 8.4.x and 07ebc39 to 8.3.x. Thanks!

Committed to to 8.3.x because it is mostly adding test coverage. Yes there is a change to the view operation whilst access handling but this is just to call the parent access handler and is correct. Viewing config entities is weird.

  • alexpott committed 66c750c on 8.4.x 
    Issue #2843761 by vaplas, Wim Leers: EntityResource: Provide...

  • alexpott committed 07ebc39 on 8.3.x 
    Issue #2843761 by vaplas, Wim Leers: EntityResource: Provide...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.