Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
I don't think having this hook makes sense given the field is an entity base field and not a field attached to a bundle. Possibly left over from the previous implementation.
Proposed resolution
Remove code and see what the testbot says.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2843678-remove-dead-code-2.patch | 2 KB | Sam152 |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #3
timmillwoodThis kinda makes me wonder if we need to a test to loop through all entity types (content and config) to assert the
moderation_stateis on the entity types it should be, and not on the entity types it shouldn't be. Thoughts?Comment #4
dawehnerTrue, we are adding it at
core/modules/content_moderation/src/EntityTypeInfo.php:305now.Nice catch and simplification!
Comment #5
alexpottCommitted 8af814f and pushed to 8.3.x. Thanks!