When editing an archived node, the save options are

"Save and Un-archive to draft"
or
"Save and Un-archive"

Save and Un-archive

How about we change these to say

"Save to restore to new draft"
or
"Save to restore and publish"

Save to restore new draft mockup

CommentFileSizeAuthor
#4 2843567-4.patch700 bytesSam152
save_and_un-archive.jpg7.71 KBkattekrab
save_to_restore_draft.jpg8.14 KBkattekrab
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kattekrab created an issue. See original summary.

Thew’s picture

Thew CreditAttribution: Thew at Google Code-In commented

They're the transition label from default config.
The label is concatenated with Save and.

So, I suggest these words:
Save and Restore as New Draft
Save and Restore

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

+1

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Needs review
FileSize
2843567-4.patch700 bytes

+1, seems reasonable.

Lets see what testbot says.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Usablity

Do we need an upgrade path? Maybe not because workflows is an alpha release. Anyway, patch looks good.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

I'm a little shocked that this change doesn't fail any tests, so maybe we need some? could be a follow up.

We don't need an upgrade path because it's experimental.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

I think of most of tests which really flex the different states/transitions use the machine name in a kernel test. Maybe some UI, but perhaps this is a good sign we're testing the code not the config.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2843567-4.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Reviewed & tested by the community
wturrell’s picture

wturrell CreditAttribution: wturrell as a volunteer commented
Issue tags: +String change in 8.3.0
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Agreed this is reasonable to go in as-is.

Committed/pushed to 8.3.x, thanks!

  • catch committed 2e4a1c7 on 8.3.x 
    Issue #2843567 by Sam152, kattekrab: Change "Un-archive" transition...
kattekrab’s picture

kattekrab CreditAttribution: kattekrab at Catalyst IT commented

Yay!

Thanks all :)

  • catch committed 2e4a1c7 on 8.4.x 
    Issue #2843567 by Sam152, kattekrab: Change "Un-archive" transition...

  • catch committed 2e4a1c7 on 8.4.x 
    Issue #2843567 by Sam152, kattekrab: Change "Un-archive" transition...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.