Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Diff test is failing in ERR is failing.
Proposed resolution
Fix the test in ERR.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#15 | fix-2843061-15.patch | 1.42 KB | Ginovski |
| |||
#13 | new-diff-test-debug.patch | 924 bytes | Ginovski |
#11 | debug-diff-test.patch | 665 bytes | Ginovski |
#8 | fix-2843061-8-with-composer.patch | 1.33 KB | Ginovski |
#8 | fix-2843061-8.patch | 675 bytes | Ginovski |
Comments
Comment #2
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedChanged the drupalPostForm in the test accordingly.
Comment #3
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedComment #5
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedComment #6
johnchqueThis will work when we get a new Diff release. :) Meanwhile postponed.
Comment #7
BerdirI don't understand why this is postponed. The button rename is not yet in a release, but why is already failing then in #2801321: New host revisions do not always create new composite entity revisions, that makes no sense?
We could add a composer.json with a require-dev dependency on diff 1.x-dev to get the latest version already, so we don't have to fix it twice. With the downside of having to update that again after there is a release.
Comment #8
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedUploaded 2 version:
1. With composer.json, require-dev on diff - latest version working
2. Without require-dev, current version working
Comment #11
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedDebug in the test.
Comment #13
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented1. Added debug and the new button name
Comment #15
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedSince composer is installing the dependencies, it installed visual inline, which shouldn't be there by default.
1. Added config disable for the visual inline in the setup
2. Fixed the button name and raw assertion.
Comment #16
johnchqueRight! Didn't think about that. :)
Comment #18
johnchqueCommitted => Fixed. :)