Problem/Motivation

Diff test is failing in ERR is failing.

Proposed resolution

Fix the test in ERR.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#15 fix-2843061-15.patch1.42 KBGinovski
#13 new-diff-test-debug.patch924 bytesGinovski
#11 debug-diff-test.patch665 bytesGinovski
#8 fix-2843061-8-with-composer.patch1.33 KBGinovski
#8 fix-2843061-8.patch675 bytesGinovski
#2 fix-2843061-2.patch766 bytesGinovski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ginovski created an issue. See original summary.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
FileSize
fix-2843061-2.patch766 bytes

Changed the drupalPostForm in the test accordingly.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: fix-2843061-2.patch, failed testing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Issue summary: View changes
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Postponed

This will work when we get a new Diff release. :) Meanwhile postponed.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Postponed » Needs work

I don't understand why this is postponed. The button rename is not yet in a release, but why is already failing then in #2801321: New host revisions do not always create new composite entity revisions, that makes no sense?

We could add a composer.json with a require-dev dependency on diff 1.x-dev to get the latest version already, so we don't have to fix it twice. With the downside of having to update that again after there is a release.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
fix-2843061-8.patch675 bytes
fix-2843061-8-with-composer.patch1.33 KB

Uploaded 2 version:
1. With composer.json, require-dev on diff - latest version working
2. Without require-dev, current version working

The last submitted patch, 8: fix-2843061-8.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: fix-2843061-8-with-composer.patch, failed testing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
debug-diff-test.patch665 bytes

Debug in the test.

Status: Needs review » Needs work

The last submitted patch, 11: debug-diff-test.patch, failed testing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
new-diff-test-debug.patch924 bytes

1. Added debug and the new button name

Status: Needs review » Needs work

The last submitted patch, 13: new-diff-test-debug.patch, failed testing.

Ginovski’s picture

Ginovski CreditAttribution: Ginovski at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
fix-2843061-15.patch1.42 KB

Since composer is installing the dependencies, it installed visual inline, which shouldn't be there by default.
1. Added config disable for the visual inline in the setup
2. Fixed the button name and raw assertion.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Right! Didn't think about that. :)

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed => Fixed. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.