Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2602662: Feed ID should be required base field for aggregator items made the 'Source feed' required for aggregator items, but the update function was untested and did not actually update the field.
Proposed resolution
Provide a new update function and test it.
Remaining tasks
Review.
User interface changes
Nope.
API changes
Nope.
Data model changes
Nope.
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff.txt | 896 bytes | amateescu |
#5 | 2840595-5.patch | 2.43 KB | amateescu |
#2 | 2840595.patch | 2.44 KB | amateescu |
#2 | 2840595-test-only.patch | 1.46 KB | amateescu |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThis should do it.
Comment #4
BerdirInstead of "not enough" and "actually", can we explain why it was not enough? The comment doesn't really tell me anything.
Comment #5
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedYou're right, how about this one?
Comment #6
BerdirYes, that's better :)
That update was a while ago, wondering if that happend when we still had the automatic entity updates running?
Comment #7
alexpottSo I tested this in HEAD by doing this:
After this the status report doesn't say that the entity definitions for aggregator are out-of-date so perhaps there is a bug there. It does say that
So there is an update that is not working. But also shouldn't the mismatched aggregator definition be here too? So I guess we need a followup for both Comment issue and the fact that changing the requiredness of a field doesn't result in an mismatch warning.
OTOH if I looked at the field definition the field is not required so the bug is real.
Committed and pushed ffd4d6a to 8.3.x and 12fbebb to 8.2.x. Thanks!
I committed this to 8.2.x since the mismatch is a real bug and the update is not a big one.