The 'Source feed' field of aggregator items has to be updated and marked as required

+++ b/core/modules/aggregator/aggregator.install
@@ -37,3 +37,24 @@ function aggregator_update_8001() {
+function aggregator_update_8200() {
+  // An empty update function like aggregator_update_8001() is not enough, we
+  // need to actually set the base field definition as required.

Instead of "not enough" and "actually", can we explain why it was not enough? The comment doesn't really tell me anything.

Yes, that's better :)

That update was a while ago, wondering if that happend when we still had the automatic entity updates running?

So I tested this in HEAD by doing this:

1. git co 22716ab~1
2. install standard
3. install aggregator
4. rm -rf ./vendor && git co 8.3.x
5. composer install
6. run update.php

After this the status report doesn't say that the entity definitions for aggregator are out-of-date so perhaps there is a bug there. It does say that

Comment: The Publishing status field needs to be updated.

So there is an update that is not working. But also shouldn't the mismatched aggregator definition be here too? So I guess we need a followup for both Comment issue and the fact that changing the requiredness of a field doesn't result in an mismatch warning.

OTOH if I looked at the field definition the field is not required so the bug is real.

Committed and pushed ffd4d6a to 8.3.x and 12fbebb to 8.2.x. Thanks!

I committed this to 8.2.x since the mismatch is a real bug and the update is not a big one.