Follow-up to #2755663: Add a solid slider and range widget base.
Part of the work we needed to do for #2755663: Add a solid slider and range widget base made us have to change the $separator
from a contant to a protected variable. This means that we can refactor the class DummyQuery extends UrlProcessorPluginBase {
into class DummyQuery extends QueryString { protected $separator = '||'; }
and basically remove the entire implementation.
This doesn't change any of our runtime code but makes it easier to maintain the testsuite. Postponing this on that issue (that needs reviews + at least one test first).
Comment | File | Size | Author |
---|---|---|---|
#4 | cleanup_dummy_query_url-2840140-4.patch | 4.22 KB | benwitters |
Comments
Comment #2
borisson_Active, now that the original issue has been committed, tagging as novice as well, should be explained well enough
Comment #3
benwitters CreditAttribution: benwitters at iO commentedI am working on this issue.
Comment #4
benwitters CreditAttribution: benwitters at iO commentedI cleaned up the DummyQuery class and extended the QueryString.
Comment #5
borisson_Tests still pass, and the change looks great. I'll commit this later today, thanks!
Comment #7
borisson_Committed and pushed.