Follow-up to #2755663: Add a solid slider and range widget base.

Part of the work we needed to do for #2755663: Add a solid slider and range widget base made us have to change the $separator from a contant to a protected variable. This means that we can refactor the class DummyQuery extends UrlProcessorPluginBase { into class DummyQuery extends QueryString { protected $separator = '||'; } and basically remove the entire implementation.

This doesn't change any of our runtime code but makes it easier to maintain the testsuite. Postponing this on that issue (that needs reviews + at least one test first).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

Status: Postponed » Active
Issue tags: +Novice

Active, now that the original issue has been committed, tagging as novice as well, should be explained well enough

benwitters’s picture

Assigned: Unassigned » benwitters

I am working on this issue.

benwitters’s picture

Status: Active » Needs review
FileSize
4.22 KB

I cleaned up the DummyQuery class and extended the QueryString.

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Tests still pass, and the change looks great. I'll commit this later today, thanks!

borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.