Another developer let me know that the package versions seemed to still indicate 7.x versions in the module's 8.x branch inside package.json and bower.json. Both indicate 7.3.0-dev or 7.3.x-dev, when they should indicate 8.3.x-dev, most likely?

CommentFileSizeAuthor
#2 2840107-2.patch587 bytesThew
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geerlingguy created an issue. See original summary.

Thew’s picture

Thew CreditAttribution: Thew at Google Code-In commented
Status: Active » Needs review
FileSize
2840107-2.patch587 bytes

Confirmed the issue and also a patch file.

I change them to 8.3.x-dev.

Also, I checked the 7.x-3.x branch and found that in package.json the version is 7.3.0-dev. Should it be 7.3.x-dev?

gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In commented
Status: Needs review » Reviewed & tested by the community

The patch seems to fix the issue. RTBC+1

  • markcarver committed f1d9edc on 8.x-3.x authored by Thew 
    Issue #2840107 by Thew, geerlingguy: Versions are off in package.json...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Reviewed & tested by the community » Fixed

Re: 7.x-3.x

Honestly, it doesn't really matter all that much. These are really just used by project maintainers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.