API page: https://api.drupal.org/api/drupal/core%21core.api.php/group/form_api/8.2.x

Enter a descriptive title (above) referring to Form generation, then describe the problem you have found:

The following statement is wrong:

The argument to \Drupal::formBuilder()->getForm() is the name of a class that implements FormBuilderInterface.

It should be:
The argument to \Drupal::formBuilder()->getForm() is the name of a class that implements FormInterface.

CommentFileSizeAuthor
#12 interdiff-2839267-9-12.txt608 byteser.pushpinderrana
#12 2839267-11.patch608 byteser.pushpinderrana
#9 2839267-9.patch518 bytesjoyceg
#7 2839267-7-DocumentationImprovement.patch518 byteschiranjeeb2410
#3 form_generation_core_api-1.patch55.66 KBchiranjeeb2410
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oldpopsong created an issue. See original summary.

chiranjeeb2410’s picture

chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented
Assigned: Unassigned » chiranjeeb2410
chiranjeeb2410’s picture

chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented
Title: Argument of \Drupal::formBuilder()->getForm() should implements FormInterface » Argument of \Drupal::formBuilder()->getForm() should implement FormInterface
Issue summary: View changes
FileSize
form_generation_core_api-1.patch55.66 KB

This should work. Rephrased "FormBuilderInterface" as "FormInterface".

chiranjeeb2410’s picture

chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: form_generation_core_api-1.patch, failed testing.

joyceg’s picture

joyceg CreditAttribution: joyceg commented

@chiranjeeb2410,

I think you have ended up uploading an entire program file. Please upload only the patch commit.

chiranjeeb2410’s picture

chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented
Status: Needs work » Needs review
FileSize
2839267-7-DocumentationImprovement.patch518 bytes

Made necessary changes. Applying new patch here.

Status: Needs review » Needs work

The last submitted patch, 7: 2839267-7-DocumentationImprovement.patch, failed testing.

joyceg’s picture

joyceg CreditAttribution: joyceg commented
Status: Needs work » Needs review
FileSize
2839267-9.patch518 bytes
chiranjeeb2410’s picture

chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented
Status: Needs review » Reviewed & tested by the community

@joyceg,

Thanks, patch applies well. Changing status to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/core.api.php
@@ -1721,7 +1721,7 @@
- * implements FormBuilderInterface. Any additional arguments passed to the
+ * implements FormInterface. Any additional arguments passed to the

the comment needs re-flowing. getForm() will now fit on the previous line.

er.pushpinderrana’s picture

er.pushpinderrana CreditAttribution: er.pushpinderrana as a volunteer and at Publicis Sapient for Publicis Sapient commented
Status: Needs work » Needs review
FileSize
2839267-11.patch608 bytes
interdiff-2839267-9-12.txt608 bytes

Rearrange the patch as required.

chiranjeeb2410’s picture

chiranjeeb2410 CreditAttribution: chiranjeeb2410 commented
Status: Needs review » Reviewed & tested by the community

@pushpinderrana,

Thanks, patch applies well.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1ff29a3 to 8.4.x and 520d1d0 to 8.3.x. Thanks!

  • alexpott committed 1ff29a3 on 8.4.x 
    Issue #2839267 by chiranjeeb2410, er.pushpinderrana, joyceg, oldpopsong...

  • alexpott committed 520d1d0 on 8.3.x 
    Issue #2839267 by chiranjeeb2410, er.pushpinderrana, joyceg, oldpopsong...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.