currently DevelEventSubscriber collects heterogeneous methods used for different functionalities.
The idea is to split DevelEventSubscriber into multiple classes each of which encapsulate the methods for a single functionality.
By splitting up DevelEventSubscriber we obtain better logical grouping and better maintainability.

CommentFileSizeAuthor
#6 split-2832882-6.patch10.52 KBwillzyx
#3 split-2832882-3.patch29.62 KBwillzyx
#2 split-2832882-2.patch28.32 KBwillzyx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx created an issue. See original summary.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Active » Needs review
FileSize
split-2832882-2.patch28.32 KB
willzyx’s picture

willzyx CreditAttribution: willzyx commented
FileSize
split-2832882-3.patch29.62 KB

sorry I'm missing to add some files in the previous patch

The last submitted patch, 2: split-2832882-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: split-2832882-3.patch, failed testing.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
FileSize
split-2832882-6.patch10.52 KB

And of course migrate DevelErrorHandlerTest from WebTestBase to BrowserTestBase is out of scope for this issue (or at least not a priority).. sorry for the noise :P

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Needs work » Needs review
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Title: Split DevelEvenSubscriber into multiple classes » Split DevelEventSubscriber into multiple classes
Issue summary: View changes
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Needs review » Reviewed & tested by the community
willzyx’s picture

willzyx CreditAttribution: willzyx commented

give to other maintainers some other time to review the patch.. I will commit this in a couple of days

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

This looks great to me. Thanks @willzx

  • willzyx committed d3d4eae on 8.x-1.x 
    Issue #2832882 by willzyx: Split DevelEventSubscriber into multiple...
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.