Problem/Motivation

/user is a redirect in 8.x if you are not logged in. Right now all browser tests need to do an additional, useless roundtrip when logging in.

Each request doesn't make a bug difference but we are obviously doing this *a lot* across all tests, so this should help a small bit.

Proposed resolution

Change /user to /user/login in that method.

Remaining tasks

Verify manually that we save a request with the verbose output.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2832080-1.patch544 bytescebasqueira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Issue summary: View changes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: \Drupal\Tests\BrowserTestBase::drupalLogin() does an unnecessary redirect from /user to /user/login for each login » BrowserTestBase::drupalLogin() does an unnecessary redirect from /user to /user/login for each login
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Component: simpletest.module » phpunit
cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
Status: Active » Needs review
FileSize
2832080-1.patch544 bytes

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

programemos’s picture

programemos CreditAttribution: programemos as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

I applied the patche and everything is working correctly

programemos’s picture

programemos CreditAttribution: programemos as a volunteer and commented
Issue tags: +SprintWeekend2017
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Nice find. Committed and pushed ac55a70 to 8.4.x and 61a0850 to 8.3.x. Thanks!

  • alexpott committed ac55a70 on 8.4.x 
    Issue #2832080 by cebasqueira, Berdir: BrowserTestBase::drupalLogin()...

  • alexpott committed 61a0850 on 8.3.x 
    Issue #2832080 by cebasqueira, Berdir: BrowserTestBase::drupalLogin()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.