If we do have the library came up with the profile. it should recognize that the library exists

CommentFileSizeAuthor
#7 2830862-7.patch977 bytesRajab Natshah
#4 2830862-4.patch1.14 KBRajab Natshah
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RajabNatshah created an issue. See original summary.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Title: Updated the requirements on installation for [dropzonejs] so it will work If the library not in the profile path too » Updated the requirements on installation for [dropzonejs] so it will work If the library is not in the profile path too
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Title: Updated the requirements on installation for [dropzonejs] so it will work If the library is not in the profile path too » Updated the requirements on installation for [dropzonejs] so it will work If the library is not in the installation profile path too
Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Issue summary: View changes
FileSize
2830862-4.patch1.14 KB

This is the patch to make it work if the library was in the installation profile.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Title: Updated the requirements on installation for [dropzonejs] so it will work If the library is not in the installation profile path too » Updated the requirements on installation for [dropzonejs] to make it work if the library was in the installation profile.
Assigned: Rajab Natshah » Unassigned
Status: Needs work » Needs review
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented

This is a nice improvement. Just one suggestion:

+++ b/dropzonejs.install
@@ -18,13 +18,17 @@
+    if (!file_exists($profile_path)) {

Can we check both paths in the same if?

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
FileSize
2830862-7.patch977 bytes

Bettered up the logic.

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented

  • Primsi committed 110304b on 8.x-1.x authored by RajabNatshah 
    Issue #2830862 by RajabNatshah, Primsi: Make requirements work if the...
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.