Problem/Motivation

The order of the filters on the Content overview page is different than the columns they relate to.
This makes the admin pages looking more chaotic then it should be.

“Screenshot

Proposed resolution

Reorder the filters in the view to Title, Content type, Status and then Language (which isn't displayed in a column so should be at the end.)

Remaining tasks

Create Patch

User interface changes

This is a UI change but does not require any changes in the help text or new string translations.

CommentFileSizeAuthor
#10 interdiff-5-10.txt3.39 KBrosinegrean
#10 order_content_filters-2830449-10.patch8.19 KBrosinegrean
#6 content-filters-reordered.png12.09 KBifrik
#5 order_content_filters-2830449-5.patch4.8 KBrosinegrean
content-view-filter-order.png15.47 KBifrik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

hardikpandya’s picture

hardikpandya CreditAttribution: hardikpandya at Iksula commented
Assigned: Unassigned » hardikpandya
hardikpandya’s picture

hardikpandya CreditAttribution: hardikpandya at Iksula commented
Assigned: hardikpandya » Unassigned
rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Assigned: Unassigned » rosinegrean
rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Assigned: rosinegrean » Unassigned
Status: Active » Needs review
FileSize
order_content_filters-2830449-5.patch4.8 KB

Is something else required except for the update of the .yml file for the view ?

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +drupalironcamp2016
FileSize
content-filters-reordered.png12.09 KB

Thanks, this works as intended.
“Content

The new configuration is only used when the Drupal site is installed. It doesn't change existing sites. I've just checked with dawehner and that's fine because it's easy to change manually on existing sites.
Therefore just the yaml file is fine.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Title: Order Content filters according to column order » Order filters according to column order on default administrative views
Component: node system » views.module
Status: Reviewed & tested by the community » Needs work

This seems like a sensible UX improvement -- the illustration in the summary says it all.

I agree that it is okay to just fix this for new installations -- after all, existing installations may have already customized the view.

I noticed admin/people has a similar problem. Can we fix that view here too? admin/content/files seems to be in the correct order already.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

prics,
Do you want to change that second view as well?

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Assigned: Unassigned » rosinegrean

@ifrik, yes, i will update the patch tomorrow.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Assigned: rosinegrean » Unassigned
Status: Needs work » Needs review
FileSize
order_content_filters-2830449-10.patch8.19 KB
interdiff-5-10.txt3.39 KB

Here we go, patch and the interdiff for it.

Status: Needs review » Needs work

The last submitted patch, 10: order_content_filters-2830449-10.patch, failed testing.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Status: Needs work » Needs review

I'm not sure why, it passes all tests, but the issue is set in needs work.
Any clue?
I will just add it in needs review again.

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Status: Needs review » Reviewed & tested by the community

Thanks,
both the list of content and the list of users now have the filters in the same order as the columns underneath on a fresh install.

  • xjm committed 28ecd0c on 8.3.x 
    Issue #2830449 by prics, ifrik, hardik.p: Order filters according to...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +8.3.0 release notes

Committed 28ecd0c and pushed to 8.3.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks for getting this fixed and committed so fast.

It's one of those small things that often don't seem to be worth the bother, but then we can just fix it for lots of users.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary commented
Status: Fixed » Closed (fixed)
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -sprint