Currently when using the dynamic_entity_reference_options_select widget, the options are shown in optgroups.

Patch attached only shows the items in optgroups when there are multiple target_bundles available.

CommentFileSizeAuthor
#7 interdiff-2829602-2-7.txt1.96 KBJeroenT
#7 disable_optgroup_in-2829602-7.patch2.94 KBJeroenT
#7 disable_optgroup_in-2829602-7-test-only.patch2.09 KBJeroenT
#5 2829602-after.png12.29 KBJeroenT
#5 2829602-before.png13.57 KBJeroenT
#2 disable_optgroup_in-2829602-2.patch870 bytesJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT created an issue. See original summary.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Active » Needs review
FileSize
disable_optgroup_in-2829602-2.patch870 bytes

Currently when using the dynamic_entity_reference_options_select widget, the options are shown in optgroups.

Patch attached only shows the items in optgroups when there are multiple target_bundles available.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Issue summary: View changes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Can you please add screenshots for this and some quick test?

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Issue tags: +Need tests
FileSize
2829602-before.png13.57 KB
2829602-after.png12.29 KB

Attached is a before and after screenshot.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Needs work

Thanks for the screenshots. These look awesome. Let's add some tests and finish it.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
Issue tags: -Need tests
FileSize
disable_optgroup_in-2829602-7-test-only.patch2.09 KB
disable_optgroup_in-2829602-7.patch2.94 KB
interdiff-2829602-2-7.txt1.96 KB

Created a test.

The last submitted patch, 7: disable_optgroup_in-2829602-7-test-only.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

This is ready.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Awesome work with the tests. Thank you!

  • jibran committed 359e650 on 8.x-2.x authored by JeroenT 
    Issue #2829602 by JeroenT: Disable optgroup in select list when only 1...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Pushed to 8.x-1.x

  • jibran committed fd781f1 on 8.x-1.x authored by JeroenT 
    Issue #2829602 by JeroenT: Disable optgroup in select list when only 1...

  • jibran committed be7ef19 on 8.x-1.x 
    Issue #2829602 by jibran: PHPCS fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.