Actual hook implementations need to be in the module, but the bulk of the code can be in a service.

CommentFileSizeAuthor
#6 imageapi_optimize-2829536-hooks.patch4.41 KBSteven Jones
#2 imageapi_optimize-2829536-move-hook-implementations.patch4.58 KBSteven Jones
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Jones created an issue. See original summary.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Active » Needs review
FileSize
imageapi_optimize-2829536-move-hook-implementations.patch4.58 KB

Something like this.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Needs work
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs work » Needs review
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Needs work

I added a hook in the latest version.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs work » Needs review
FileSize
imageapi_optimize-2829536-hooks.patch4.41 KB

  • Steven Jones committed 30a602e on 8.x-2.x 
    Issue #2829536 by Steven Jones: Move hook implementations into a service
Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.