Webprofiler code is very untested, let's do a better coverage.

Test to be written:

  • Test that the toolbar appears on non-excluded paths
  • Test that the toolbar doesn't appears on excluded url
  • Test that selected widgets appear on the toolbar
  • Write a test for every datacollector
  • Test that the various storages work
  • more to be defined...
CommentFileSizeAuthor
#22 write_test_for-2827852-22.patch12.68 KBlussoluca
#21 write_test_for-2827852-21.patch17.48 KBlussoluca
#20 write_test_for-2827852-20.patch17.88 KBlussoluca
#19 write_test_for-2827852-19.patch17.74 KBlussoluca
#18 write_test_for-2827852-18.patch17.72 KBlussoluca
#17 write_test_for-2827852-17.patch21.88 KBlussoluca
#16 write_test_for-2827852-16.patch21.85 KBlussoluca
#15 write_test_for-2827852-14.patch0 byteslussoluca
#13 write_test_for-2827852-13.patch14.84 KBlussoluca
#11 write_test_for-2827852-11.patch10.1 KBlussoluca
#10 write_test_for-2827852-10.patch9.47 KBlussoluca
#7 write_test_for-2827852-7.patch9.42 KBlussoluca
#5 write_test_for-2827852-5.patch9.42 KBlussoluca
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lussoluca created an issue. See original summary.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Related issues: +#2825426: Call to a member function get() on null @ BlocksDataCollector->getBlocksData()
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Related issues: +#2617392: [plan] Webprofiler roadmap
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Issue tags: +SprintWeekend2017
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Active » Needs review
FileSize
write_test_for-2827852-5.patch9.42 KB

First test try

Status: Needs review » Needs work

The last submitted patch, 5: write_test_for-2827852-5.patch, failed testing.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-7.patch9.42 KB
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: write_test_for-2827852-7.patch, failed testing.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Needs work » Needs review
FileSize
write_test_for-2827852-10.patch9.47 KB
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-11.patch10.1 KB
willzyx’s picture

willzyx CreditAttribution: willzyx commented

I have not the time now for a full review but +1000 to the initiative!!

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-13.patch14.84 KB

Status: Needs review » Needs work

The last submitted patch, 13: write_test_for-2827852-13.patch, failed testing.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Needs work » Needs review
Issue tags: -SprintWeekend2017
FileSize
write_test_for-2827852-14.patch0 bytes

Reroll on top of latest updates.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-16.patch21.85 KB

Wrong patch file...

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-17.patch21.88 KB

Missing @group annotation in a test.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-18.patch17.72 KB
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-19.patch17.74 KB
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-20.patch17.88 KB
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-21.patch17.48 KB
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
write_test_for-2827852-22.patch12.68 KB

  • lussoluca committed d33784c on 8.x-1.x 
    Issue #2827852 by lussoluca: Write test for Webprofiler
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Needs review » Needs work

I'm going to commit this first set of tests that ensures the toolbar visibility in page.
Tests fails in D8.4 because of #2879214: Support for Drupal 8.4.x using Symfony 3 in webprofiler.