Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Webprofiler code is very untested, let's do a better coverage.
Test to be written:
- Test that the toolbar appears on non-excluded paths
- Test that the toolbar doesn't appears on excluded url
- Test that selected widgets appear on the toolbar
- Write a test for every datacollector
- Test that the various storages work
- more to be defined...
Comment | File | Size | Author |
---|---|---|---|
#22 | write_test_for-2827852-22.patch | 12.68 KB | lussoluca |
#21 | write_test_for-2827852-21.patch | 17.48 KB | lussoluca |
#20 | write_test_for-2827852-20.patch | 17.88 KB | lussoluca |
#19 | write_test_for-2827852-19.patch | 17.74 KB | lussoluca |
#18 | write_test_for-2827852-18.patch | 17.72 KB | lussoluca |
Comments
Comment #2
lussolucaComment #3
lussolucaComment #4
lussolucaComment #5
lussolucaFirst test try
Comment #7
lussolucaComment #8
lussolucaComment #10
lussolucaComment #11
lussolucaComment #12
willzyx CreditAttribution: willzyx commentedI have not the time now for a full review but +1000 to the initiative!!
Comment #13
lussolucaComment #15
lussolucaReroll on top of latest updates.
Comment #16
lussolucaWrong patch file...
Comment #17
lussolucaMissing @group annotation in a test.
Comment #18
lussolucaComment #19
lussolucaComment #20
lussolucaComment #21
lussolucaComment #22
lussolucaComment #24
lussolucaI'm going to commit this first set of tests that ensures the toolbar visibility in page.
Tests fails in D8.4 because of #2879214: Support for Drupal 8.4.x using Symfony 3 in webprofiler.