During order refresh, promotions are loaded. Promotions that target order items may be processed. These will then throw missing context errors.

the applies method should ensure the offer type target entity matches the incoming entity.

CommentFileSizeAuthor
#4 interdiff-2-4.txt1.81 KBmitrpaka
#4 promotions_should-2826222-4.patch2.79 KBmitrpaka
#3 interdiff-2-3.txt1.79 KBmitrpaka
#3 promotions_should-2826222-3.patch2.77 KBmitrpaka
#2 promotions_should-2826222-2.patch869 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
Status: Active » Needs work
Issue tags: +Needs tests
FileSize
promotions_should-2826222-2.patch869 bytes

This gets it working. However we need tests on this.

mitrpaka’s picture

mitrpaka CreditAttribution: mitrpaka as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
promotions_should-2826222-3.patch2.77 KB
interdiff-2-3.txt1.79 KB

Tests added.

mitrpaka’s picture

mitrpaka CreditAttribution: mitrpaka as a volunteer commented
FileSize
promotions_should-2826222-4.patch2.79 KB
interdiff-2-4.txt1.81 KB

Tests added.

#PR: https://github.com/drupalcommerce/commerce/pull/568

  • mglaman committed 5c7ffac on 8.x-2.x authored by mitrpaka 
    Issue #2826222 by mitrpaka, mglaman: Promotions should verify the offer...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for Bluespark commented
Status: Needs review » Fixed

Thanks for the tests! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.