I just detected a minor typo in core/modules/migrate/tests/src/Kernel/process/DownloadTest.php that should be fixed. Patch to follow soon.

CommentFileSizeAuthor
#2 fix_spelling_of-2826038-2.patch720 bytesdermario
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dermario created an issue. See original summary.

dermario’s picture

dermario
Primary language German
Location Zürich
CreditAttribution: dermario at Unic commented
Assigned: dermario » Unassigned
Status: Active » Needs review
FileSize
fix_spelling_of-2826038-2.patch720 bytes
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • xjm committed cbbd721 on 8.3.x 
    Issue #2826038 by dermario: Fix spelling of testWriteProectedDestination

  • xjm committed 05b710e on 8.2.x 
    Issue #2826038 by dermario: Fix spelling of testWriteProectedDestination...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Since this is a test method name, it is considered internal API and BC is not required. I grepped and confirmed that we don't have the mispelling "proected" anywhere else in core.

Misspelled function and variable names can also be considered a bug, especially as they can to lead to other bugs being introduced.

Committed and pushed to 8.3.x and 8.2.x. Thanks @dermario!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.