We set the input type to email for the login form's email input, but we don't do the same for the password reset form.

CommentFileSizeAuthor
#2 pass_reset_input_type_email-2825909-2.patch558 byteseanushan

Comments

EAnushan created an issue. See original summary.

eanushan’s picture

eanushan commented
Status: Active » Needs review
StatusFileSize
new pass_reset_input_type_email-2825909-2.patch558 bytes
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Needs work

Good catch!

+++ b/email_registration.module
@@ -132,6 +132,9 @@ function email_registration_form_user_register_form_alter(&$form, FormStateInter
+  $form['name']['#maxlength'] = Email::EMAIL_MAX_LENGTH;

Missing use statement.

eanushan’s picture

eanushan commented

The use statement is already at the top of the file. It was used for the same max length restriction on the user login page.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

Oops, was looking at the wrong version.

  • andypost committed 116dc2e on 8.x-1.x authored by EAnushan 
    Issue #2825909 by EAnushan: Password Reset Email Field Type
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Thanx for contribution! looks nice

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.