Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The plan is in #2761041: [META] Commerce Shipping 8.x.
Before I create a bunch of issues for contributors to work on, I'm going to create some initial structure. That includes the shipping method plugin (converted from the shipping service in the current codebase) and matching entity.
Comments
Comment #2
bojanz CreditAttribution: bojanz at Centarro commentedCurrent progress up at https://github.com/bojanz/commerce_shipping
I'll do another rebase in the morning then push it to d.o once googletorp grants me access.
Comment #3
googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented@bojanz
Quickly browsed through the code, looks good and a lot of progress already.
Before we get started, we need to agree on how the naming conventions should be. One of the big changes in naming from 7.x-1.x to 7.x-2.x which Ryan spearheaded was the concept of shipping service and shipping method.
A shipping service could be:
- Flat rate
- UPS
- GLS
- ect
Each shipping service could then provide one or more shipping methods, fx
- Flat rate 2$ per product
- Flat rate 5$ per product type
- etc
From quickly reading the code you made, it seems like shipping service and shipping method, is now shipping method. Any reason for this change of concept?
Comment #4
bojanz CreditAttribution: bojanz at Centarro commentedEvery shipping API I've looked at (from USPS to the generic ones like Shippo) has the concept of services (or "service levels").
That's "FedEx overnight", "USPS Priority", etc. So I've kept that concept as-is.
Shipping methods are our own abstraction (similar to payment gateways) that separates the different APIs.
Comment #6
bojanz CreditAttribution: bojanz at Centarro commentedBoom.
Thanks to googletorp for the review, we caught a number of small issues (module name, missing commerce_price dependency, invalid @group in tests).