Problem/Motivation

Multistep forms usually use form rebuilding and a 'step' value to maintain their place in the flow.

\Drupal\migrate_drupal_ui\Form\MigrateUpgradeForm incorrectly uses form *values* for this, which can cause issues under certain circumstances.

Proposed resolution

Use form storage instead.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2821774-migrate-2.patch1.39 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett as a volunteer commented
Status: Active » Needs review
FileSize
2821774-migrate-2.patch1.39 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Nice find. I don't think this needs tests, since it was Migrate misusing the Form API and not an actual regression or anything like that.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed a63e841 to 8.3.x and 7811702 to 8.2.x. Thanks!

Committed to 8.2.x because migrate UI is experimental.

  • alexpott committed a63e841 on 8.3.x 
    Issue #2821774 by tim.plunkett: MigrateUpgradeForm incorrectly using...

  • alexpott committed 7811702 on 8.2.x 
    Issue #2821774 by tim.plunkett: MigrateUpgradeForm incorrectly using...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.