Problem/Motivation

When migrating a multilingual site, the migration overview page says that the translation upgrade path is missing, although it was done in #2225775: Migrate Drupal 6 core node translation to Drupal 8.
upgrade

How to reproduce

  • Enable the "Content translation" module on the D6 site and on the D8 site.
  • On the D8 site, got to "/upgrade" and fill in the D6 database credentials.
  • Actual result: translation upgrade path is missing
  • Expected result: translation upgrade path is not missing

Proposed resolution

Modify the mapping for the d6_node_translation in Drupal\migrate_drupal_ui\Form\MigrateUpgradeForm to have translation as the source module and content_translation as the destination module.

Remaining tasks

Write a patch. Review.

User interface changes

The translation upgrade path won't be marked as missing when migrating multilingual sites.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#10 after.png31.15 KBmaxocub
#6 translation_upgrade_path_missing-2809115-6.patch698 bytesyogeshmpawar
#3 2809115_translation_upgrade_path_missing.patch732 bytespetiar
upgrade.png32.01 KBmaxocub
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

maxocub created an issue. See original summary.

petiar’s picture

petiar CreditAttribution: petiar as a volunteer commented

I am on DrupalCon 2016 in Dublin and I am working on this issue.

petiar’s picture

petiar CreditAttribution: petiar as a volunteer commented
FileSize
2809115_translation_upgrade_path_missing.patch732 bytes

Problem successfully reproduced, changes made as per Proposed resolution, problem disappeared. See proposed patch.

petiar’s picture

petiar CreditAttribution: petiar as a volunteer commented
Status: Active » Needs review
Issue tags: +Dublin2016

Status: Needs review » Needs work

The last submitted patch, 3: 2809115_translation_upgrade_path_missing.patch, failed testing.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Status: Needs work » Needs review
FileSize
translation_upgrade_path_missing-2809115-6.patch698 bytes

I have rerolled the patch against #3 for 8.3.x

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me.

ricardoamaro’s picture

ricardoamaro CreditAttribution: ricardoamaro as a volunteer and at Acquia commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs screenshot
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs screenshot

Don't agree that it needs a screenshot, the only difference is the translation migration will not be missing.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
FileSize
after.png31.15 KB

Here's an after screenshot
after

ricardoamaro’s picture

ricardoamaro CreditAttribution: ricardoamaro as a volunteer and at Acquia commented

@maxocub++ thanks! Looks fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 064f776 to 8.3.x and bf894e4 to 8.2.x. Thanks!

  • alexpott committed 064f776 on 8.3.x 
    Issue #2809115 by petiar, Yogesh Pawar, maxocub: When migrating a...

  • alexpott committed bf894e4 on 8.2.x 
    Issue #2809115 by petiar, Yogesh Pawar, maxocub: When migrating a...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -sprint

Superb, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer and commented