Problem/Motivation

DER 8.x-2.x has a different column for JOINs than the column used for storage.

Proposed resolution

Factor out the relationship entity table join into a method so DER can override it in #2808337: Make use of proposed entity table relationship refactor

Remaining tasks

Commit. There's no need for a test, the existing tests suffice as there's no change whatsoever.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2808333_3.patch2.27 KBchx
#2 2808333_2.patch2.12 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx created an issue. See original summary.

chx’s picture

chx CreditAttribution: chx commented
Status: Active » Needs review
FileSize
2808333_2.patch2.12 KB
chx’s picture

chx CreditAttribution: chx commented
Issue summary: View changes
FileSize
2808333_3.patch2.27 KB
chx’s picture

chx CreditAttribution: chx commented
Issue summary: View changes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Related issues: +#2808337: Make use of proposed entity table relationship refactor

The patch just moves two line of code to a function which should be fine imo. I talked about this with @berdir and he is also fine by it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2808333_3.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Reviewed & tested by the community 
17:26:09 Slave went offline during the build
17:26:09 ERROR: Connection was broken: java.io.IOException: Connection aborted:

Retesting it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Seems a sane refactoring to help DER.

  • alexpott committed 4b50565 on 8.3.x 
    Issue #2808333 by chx: Factor out the join from Tables.php

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.