The unit tests of User's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#9 2807947-9.patch34.13 KBsvendecabooter
#6 2807947-6.patch33.33 KBmaijs
#2 2807947-2.patch33.5 KBmaijs
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

maijs’s picture

maijs CreditAttribution: maijs as a volunteer and at Wunder commented
Status: Active » Needs review
Issue tags: +Dublin2016
FileSize
2807947-2.patch33.5 KB

This patch converts migrate source plugin tests in user module from Unit namespace to Kernel namespace to take advantage of MigrateSqlSourceTestBase base class.

Some additional test coverage added to ProfileFieldTest class to cover handling of profile field of type selection.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Great, thx.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2807947-2.patch, failed testing.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue tags: +Needs reroll

Needs reroll, #2810071: d6_profile_field_values processes rows multiple times got in first.

maijs’s picture

maijs CreditAttribution: maijs as a volunteer and at Wunder commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2807947-6.patch33.33 KB
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Great work. Thx.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

See #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array keys to make it easier to understand what is going on.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Status: Needs work » Needs review
FileSize
2807947-9.patch34.13 KB

Updated the patch to have more informative keys (next to descriptive comments) as suggested by alexpott

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Ah, the end is near....

Thank again!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed a7c5f10 to 8.3.x and 4f51e0b to 8.2.x. Thanks!

  • alexpott committed a7c5f10 on 8.3.x 
    Issue #2807947 by maijs, svendecabooter, quietone: Convert User's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.