The unit tests of Node's Migrate source plugins should be changed to the base class introduced in #2791119: Write meaningful Migrate source tests.

CommentFileSizeAuthor
#6 2807917-6.patch72.45 KBsvendecabooter
#4 2807917-4.patch71.97 KBsvendecabooter
#3 2807917-3.patch71.98 KBsvendecabooter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Assigned: Unassigned » svendecabooter
svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
Assigned: svendecabooter » Unassigned
Status: Active » Needs review
FileSize
2807917-3.patch71.98 KB
svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
FileSize
2807917-4.patch71.97 KB

Now with code style fixes.

chipway’s picture

chipway CreditAttribution: chipway at Chipway commented

I would add here what alexpott suggested in order to help to review then commit it:
See #2807879-14: Convert Contact's Migrate source tests to new base class - let's use better array in/out keys to make it easier to understand what is going on.

svendecabooter’s picture

svendecabooter
Primary language Dutch
Location Gent
CreditAttribution: svendecabooter at Sven Decabooter commented
FileSize
2807917-6.patch72.45 KB

Updated the patch to have more informative keys (next to descriptive comments) as suggested by alexpott in #2807879: Convert Contact's Migrate source tests to new base class

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks svendecabooter!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 58d8c20 to 8.3.x and 0e6144b to 8.2.x. Thanks!

I confirmed that the new tests are running and we've not reduced the coverage.

  • alexpott committed 58d8c20 on 8.3.x 
    Issue #2807917 by svendecabooter: Convert Node's Migrate source tests to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.