Follow-up to #2764045: Adding .tpl.php file in theme templates makes test themes visible on the appearance admin form

This configuration is rarely needed and should be commented out for example purposes only. It's use-case seems to be focused towards core developers and not general environment for drupal site developers and site builders.

/**
 * Allow test modules and themes to be installed.
 *
 * Drupal ignores test modules and themes by default for performance reasons.
 * During development it can be useful to install test extensions for debugging
 * purposes.
 */
$settings['extension_discovery_scan_tests'] = TRUE;
CommentFileSizeAuthor
#2 2805449-1-comment-out-extension_discovery_scan_tests.patch456 bytesjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Active » Needs review
Issue tags: +Quick fix
FileSize
2805449-1-comment-out-extension_discovery_scan_tests.patch456 bytes

Here's the one line quickfix.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

I agree.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Version: 8.4.x-dev » 8.5.x-dev
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
CreditAttribution: sorabh.v6 at Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

I can confirm that $settings['extension_discovery_scan_tests'] = TRUE; is commented in the patch and patch applies successfully.

Thanks

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Hm, tried to commit this, but the committer git hooks get hung up on an existing coding style violation:

$ git commit -m 'Issue #2805449 by joelpittet: Comment out '\''extension_discovery_scan_tests'\'' in example.settings.local.php'

FILE: sites/example.settings.local.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 34 | ERROR | [x] Namespaced classes/interfaces/traits should be
    |       |     referenced with use statements
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 74ms; Memory: 6Mb

I would not sidestep that but also it is not really a problem with this issue... Will consult other committers.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Discussed with @xjm, we don't need to block this issue on the other fix. I committed sidestepping the validation issue for now. :) Thanks!

Opened #2915673: Ignore coding standards in sites/* PHP files as they are for configuration and not real code for the code style problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.