CommentFileSizeAuthor
opsie.patch800 byteschx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

Oopsie indeed - I've made this rc eligible since it is such a simple change to test only code.

Committed and pushed d32c1cf to 8.3.x and 536fa30 to 8.2.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Fixed » Needs review

@chx :( and now I've committed I realise you've rtbc'd your own patch. But lol my push failed - yay.

chx’s picture

chx CreditAttribution: chx at Smartsheet, Migrate Rocks commented

I am not even ashamed of RTBC'ing my own patch. Do you seriously need a review of this?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

That's perfect fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Thanks for finding this @chx and @dawehner thanks for reviewing.

Committed and pushed 918731d to 8.3.x and cbe8ae1 to 8.2.x. Thanks!

  • alexpott committed 918731d on 8.3.x 
    Issue #2803117 by chx: JavascriptTestBase catches the wrong exception

  • alexpott committed cbe8ae1 on 8.2.x 
    Issue #2803117 by chx: JavascriptTestBase catches the wrong exception

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.