FILE: ...dules/contrib/profile/tests/src/Kernel/ProfileRoleAccessTest.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------
  24 | ERROR | [ ] If the line declaring an array spans longer than
     |       |     80 characters, each element should be broken into
     |       |     its own line
  67 | ERROR | [ ] Missing short description in doc comment
 100 | ERROR | [ ] Doc comment short description must be on a single
     |       |     line, further text should be a separate paragraph
 108 | ERROR | [x] Missing function doc comment
 117 | ERROR | [ ] Doc comment short description must be on a single
     |       |     line, further text should be a separate paragraph
 149 | ERROR | [ ] Doc comment short description must be on a single
     |       |     line, further text should be a separate paragraph
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...l-8.1.9/modules/contrib/profile/tests/src/Kernel/ProfileTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
 83 | ERROR   | [x] Functions must not contain multiple empty lines
    |         |     in a row; found 2 empty lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...9/modules/contrib/profile/tests/src/Kernel/ProfileAccessTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 23 | ERROR | [ ] If the line declaring an array spans longer than 80
    |       |     characters, each element should be broken into its
    |       |     own line
 78 | ERROR | [x] Functions must not contain multiple empty lines in
    |       |     a row; found 2 empty lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...1.9/modules/contrib/profile/tests/src/Kernel/ProfileViewTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 32 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...modules/contrib/profile/tests/src/Functional/ProfileTestBase.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../contrib/profile/tests/src/Functional/ProfileFieldAccessTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 12 | ERROR | Missing short description in doc comment
 17 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------


FILE: ...les/contrib/profile/tests/src/Functional/ProfileTypeCRUDTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 44 | ERROR | Public method name "ProfileTypeCRUDTest::testCRUDUI" is
    |       | not in lowerCamel format
----------------------------------------------------------------------


FILE: ...html/drupal-8.1.9/modules/contrib/profile/src/ProfileStorage.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 31 | ERROR | [x] Array indentation error, expected 6 spaces but
    |       |     found 8
 32 | ERROR | [x] Array indentation error, expected 6 spaces but
    |       |     found 8
 33 | ERROR | [x] Array indentation error, expected 6 spaces but
    |       |     found 8
 34 | ERROR | [x] Array closing indentation error, expected 4 spaces
    |       |     but found 6
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...l-8.1.9/modules/contrib/profile/src/ProfileHtmlRouteProvider.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
 25 | ERROR   | [x] The first index in a multi-value array must be on
    |         |     a new line
 26 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found:
    |         |     '\Drupal\profile\Controller\ProfileController::addPageTitle'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...rupal-8.1.9/modules/contrib/profile/src/Form/ProfileTypeForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
   9 | ERROR | [x] There must be one blank line after the last USE
     |       |     statement; 2 found;
 111 | ERROR | [ ] Public method name
     |       |     "ProfileTypeForm::redirectToFieldUI" is not in
     |       |     lowerCamel format
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ....1.9/modules/contrib/profile/src/ProfileAccessControlHandler.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 9 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...html/drupal-8.1.9/modules/contrib/profile/src/Entity/Profile.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] There must be one blank line after the last USE
    |       |     statement; 2 found;
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../drupal-8.1.9/modules/contrib/profile/src/Entity/ProfileType.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 171 | ERROR | [x] Expected 1 blank line after function; 2 found
 174 | ERROR | [x] The closing brace for the class must have an empty
     |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...profile/src/Plugin/EntityReferenceSelection/ProfileSelection.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 28 | ERROR | [x] Expected 1 blank line after function; 0 found
 29 | ERROR | [x] The closing brace for the class must have an empty
    |       |     line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
CommentFileSizeAuthor
#7 phpcs_fixes_for_drupal_8-2802349-7.patch15.83 KBmglaman
#5 phpcs_fixes_for_drupal_8-2802349-5.patch16.57 KBmglaman
#2 phpcs_fixes_for_drupal_8-2802349-2.patch8.92 KBdishabhadra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra CreditAttribution: dishabhadra at Blisstering Solutions, Iksula commented
Status: Active » Needs review
FileSize
phpcs_fixes_for_drupal_8-2802349-2.patch8.92 KB

Below errors are not resolved as it will affect the functionality.

FILE: ...les/contrib/profile/tests/src/Functional/ProfileTypeCRUDTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 44 | ERROR | Public method name "ProfileTypeCRUDTest::testCRUDUI" is
    |       | not in lowerCamel format

FILE: ...rupal-8.1.9/modules/contrib/profile/src/Form/ProfileTypeForm.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 110 | ERROR | Public method name
     |       | "ProfileTypeForm::redirectToFieldUI" is not in
     |       | lowerCamel format
dishabhadra’s picture

dishabhadra CreditAttribution: dishabhadra at Blisstering Solutions, Iksula commented
Issue summary: View changes
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented
Status: Needs review » Needs work

2 small notes:

  • "loked" should be "locked"
  • remove "That" from the second string in the function comments. It reads better now that they are 2 sentences.

Setting to needs work but otherwise this looks great!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
phpcs_fixes_for_drupal_8-2802349-5.patch16.57 KB

Patch to fix warnings.

Status: Needs review » Needs work

The last submitted patch, 5: phpcs_fixes_for_drupal_8-2802349-5.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
phpcs_fixes_for_drupal_8-2802349-7.patch15.83 KB

  • mglaman committed cc748a6 on 8.x-1.x 
    Issue #2802349 by mglaman, dishabhadra, kscheirer: phpcs Fixes for...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.