Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2791163: Random automatic testing failures on SQLite with PHP 5.5
Problem/Motivation
The class includes an include to use file_directory_os_temp() - this is no longer necessary in 8.3.x because we have #2794249: Move file_directory_os_temp() to a class in Drupal\Component\FileSystem.
Proposed resolution
Use the new \Drupal\Component\FileSystem\FileSystem::getOsTemporaryDirectory
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2801259-2.patch | 1.04 KB | alexpott |
Comments
Comment #2
alexpottLess oddness.
Comment #3
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #5
daffie CreditAttribution: daffie commentedComment #6
Fabianx CreditAttribution: Fabianx as a volunteer commentedI think this is eligible for backport, once https://www.drupal.org/node/2794249#comment-11637189 is ported.
Comment #7
xjmThis is actually not something we would normally backport to a patch release. The location and availability of files is considered internal API, meaning we will break it in a minor but not a patch release.
We can consider it for RC but it is a disruption.
Comment #8
alexpott@xjm I agree we should only consider this for RC - otherwise revert #2791163: Random automatic testing failures on SQLite with PHP 5.5 on 8.2.x. However, for me the disruption of this issue as opposed to not doing #2791163: Random automatic testing failures on SQLite with PHP 5.5 on 8.2.x is just not comparable. What is the disruption beyond the fact that any change is in some ways a disruption - there are no API changes here and #2794249: Move file_directory_os_temp() to a class in Drupal\Component\FileSystem (which this change requires) is only additions.
Comment #10
catchCherry-picked to 8.2.x to help fix the regression in other issue.
Comment #11
xjm@alexpott and @catch and I agreed to cherry-pick all three of these issue for the RC. Can we get a CR for the combination though? I'll reopen #2794249: Move file_directory_os_temp() to a class in Drupal\Component\FileSystem for that.