Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Fix the coding standard problems outlined using the below tool:
http://pareview.sh/pareview/httpgitdrupalorgprojectcaptchagit-8x-1x
Comment | File | Size | Author |
---|---|---|---|
#59 | fix-pareview-issues-2798991-59.patch | 5.29 KB | minakshiPh |
| |||
#56 | interdiff-2798991-52-56.txt | 3.98 KB | minakshiPh |
#56 | fix-pareview-issues-2798991-56.patch | 3 KB | minakshiPh |
| |||
#52 | interdiff-2798991-48-52.txt | 9.14 KB | minakshiPh |
#52 | fix-pareview-issues-2798991-52.patch | 7.91 KB | minakshiPh |
Comments
Comment #2
naveenvalechaThe module is still in alpha state, we'll get them fixed before a beta release. There are still lots of good candidates now to get them in before this. Changing it to postponed for now.
Thanks for filing the issue.
Comment #3
naveenvalechaComment #4
naveenvalechaReopening it as I have closed couple of(~5) issues in favor of this one.
Here's the patch
Comment #5
naveenvalechaHere's the Round 2 with more fixes
Comment #6
naveenvalechaHere's the interdiff
Comment #7
naveenvalecha@elachlan ,
Can we get this fixed as its a huge patch and will be painful later to reroll it.
Comment #9
elachlan CreditAttribution: elachlan commentedIs that all of them?
Comment #10
naveenvalechaThanks! We're very now very near to it http://pareview.sh/pareview/httpgitdrupalorgprojectcaptchagit-8x-1x
Comment #11
naveenvalechaComment #12
naveenvalechaComment #14
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions, Iksula commentedComment #18
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions, Iksula commentedComment #19
shruti1803 CreditAttribution: shruti1803 at Iksula commented@Naveen
Fix coding standard issues. The patch given in #5 is failed to apply.
Comment #22
keshavv CreditAttribution: keshavv at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedHere is the patch with code standards
Comment #23
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedComment #25
naveenvalechaComment #26
yogeshmpawarI have rerolled the patch, Fix coding standards & replace the deprecated methods against 8.x-1.x
Comment #28
rasikap CreditAttribution: rasikap at Blisstering Solutions commentedComment #29
rasikap CreditAttribution: rasikap at Blisstering Solutions commentedComment #30
rasikap CreditAttribution: rasikap at Blisstering Solutions commentedComment #31
rasikap CreditAttribution: rasikap at Blisstering Solutions commentedComment #33
naveenvalechaComment #34
shruti1803 CreditAttribution: shruti1803 at Iksula commentedAdding patch again.
Comment #35
shruti1803 CreditAttribution: shruti1803 at Iksula commentedComment #37
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded the new patch.
Kindly review.
Thanks!
Comment #38
ddrozdik CreditAttribution: ddrozdik as a volunteer commentedLast submitted patch has some mistakes in comments formatting.
1.
What the reason of adding more strings. Better to investigate why those strings are commented and still present in the code.
2.
In this place indent is 4 spaces, but should be 2.
3.
Multiline comment formatting is incorrect.
@minakshiPh please take a look on the documentation https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...
Comment #39
minakshiPh CreditAttribution: minakshiPh at Iksula commentedHi @ddrozdik,
Thanks for reviewing my patch !!!
Have made the required changes as per #38
Kindly review.
Thanks!
Comment #41
elachlan CreditAttribution: elachlan commentedThere are still a heap of errors in the automated review. Thanks for your work on this.
Comment #42
minakshiPh CreditAttribution: minakshiPh at Iksula commentedHi @elachlan,
Thanks for reviewing my patch!
Added new patch to fix automated test issue Automated Testing Issue
Kindly review.
Thanks!
Comment #44
elachlan CreditAttribution: elachlan commentedThere are still quite a few outstanding issues in the pareview output. We are very close to having it resolved. Thanks for your work on this.
http://pareview.sh/pareview/httpgitdrupalorgprojectcaptchagit-8x-1x
Comment #45
minakshiPh CreditAttribution: minakshiPh at Iksula commentedComment #46
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded new patch to resolve pareview issues as mentioned in #44.
Kindly review.
Thanks!
Comment #48
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded patch to resolve pareview issues as mentioned in #44.
Kindly review.
Thanks!
Comment #51
elachlan CreditAttribution: elachlan commentedI've pushed through the documentation changes. We will have to narrow down the issues causing test failure before we push through the rest.
Comment #52
minakshiPh CreditAttribution: minakshiPh at Iksula commentedHi @elachlan,
Thanks for your helpful comments.
I have made changes in some files and tried to fix the errors.
Kindly review.
Thanks!
Comment #55
elachlan CreditAttribution: elachlan commentedI've committed the changes for white space or comments.
That will help make the patch smaller and easier to review.
Keep at it!
Comment #56
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded new patch to fix other pareview errors.
Kindly review.
Thanks!
Comment #58
elachlan CreditAttribution: elachlan commentedStill a few outstanding parview errors, but doing a lot better.
Comment #59
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded new patch to fix other pareview errors.
Kindly review.
Thanks!
Comment #62
elachlan CreditAttribution: elachlan commentedPareview is looking pretty good. The naming convention stuff I think are a false positive.
Comment #63
ddrozdik CreditAttribution: ddrozdik as a volunteer commentedLet's mark this issue as fixed, and in the future create a new issue if you want fix coding standards. Now this issue has many patches with different contexts and discussions, and it is difficult to follow it and find something.