https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Menu%21me...

CommentFileSizeAuthor
#5 interdiff-2798335-0-5.txt729 bytesnaveenvalecha
#5 2798335-5.patch1.89 KBnaveenvalecha
menu-api-php-point-unexisted-files.patch1.18 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Menu.api.php points to unexisted files » Menu.api.php references a renamed class
Version: 8.1.x-dev » 8.2.x-dev
Issue tags: +Documentation
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Component: menu system » documentation
Status: Needs review » Reviewed & tested by the community

Looks good to me.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Needs work

There is (I think) another instance of the old name in docs:

core/lib/Drupal/Core/Menu/menu.api.php: *   need can be found in \Drupal\Core\Menu\DefaultMenuTreeManipulators.
core/lib/Drupal/Core/Menu/menu.api.php: *   \Drupal\Core\Menu\DefaultMenuTreeManipulators for examples. This is only
core/lib/Drupal/Core/Menu/MenuLinkTreeInterface.php: *   \Drupal\menu_link\DefaultMenuTreeManipulators for examples.

We should always check for other places that might have the same bug when we fix issues like this one. Once we add that, though, I think this is an okay scope for this docs fix, because we do not really have a good automated mechanism for validating textual references to code.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Needs work » Needs review
FileSize
2798335-5.patch1.89 KB
interdiff-2798335-0-5.txt729 bytes

xjm, Nice find,
Find out the whole in core/ scope about the references of DefaultMenuTreeManipulators
Rerolled the attached patch

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Documentation

After applying the patch I can find no instances of 'DefaultMenuTreeManipulators' in the entire codebase.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

As a docs only patch this is RC eligible. Committed and pushed 0c29f75 to 8.3.x and 4f5da05 to 8.2.x. Thanks!

  • alexpott committed 0c29f75 on 8.3.x 
    Issue #2798335 by naveenvalecha: Menu.api.php references a renamed class

  • alexpott committed 4f5da05 on 8.2.x 
    Issue #2798335 by naveenvalecha: Menu.api.php references a renamed class...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.