To make plugins unit testable t() should be replaced by $this->t.

CommentFileSizeAuthor
#3 2797579-form-submit-after-patch.png30.35 KBjordana
#3 2797579-form-submit-before-patch.png23.89 KBjordana
#3 2797579-form-before-patch.png39.98 KBjordana
#3 2797579-form-after-patch.png25.11 KBjordana
#2 2797579-2.patch4.25 KBPradnya Pingat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pradnya Pingat created an issue. See original summary.

Pradnya Pingat’s picture

Pradnya Pingat CreditAttribution: Pradnya Pingat at Blisstering Solutions commented
Assigned: Pradnya Pingat » Unassigned
Status: Active » Needs review
FileSize
2797579-2.patch4.25 KB

Please find attached patch.

jordana’s picture

jordana
she/her
Primary language Dutch
Location Suriname
CreditAttribution: jordana as a volunteer commented
Issue summary: View changes
FileSize
2797579-form-after-patch.png25.11 KB
2797579-form-before-patch.png39.98 KB
2797579-form-submit-before-patch.png23.89 KB
2797579-form-submit-after-patch.png30.35 KB

Tested patch and both markup and display are good.
I checked both when editing the form and when submitted form.

Form Edit Before:

Form Edit After:

Form Submit Before:

Form Submit After:

jordana’s picture

jordana
she/her
Primary language Dutch
Location Suriname
CreditAttribution: jordana commented
Issue summary: View changes
jordana’s picture

jordana
she/her
Primary language Dutch
Location Suriname
CreditAttribution: jordana commented
Status: Needs review » Reviewed & tested by the community

g089h515r806’s picture

g089h515r806 CreditAttribution: g089h515r806 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.