Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The trait \Drupal\config\Tests\SchemaCheckTestTrait
doesn't belong into the config namespace, but rather into core/tests/Drupal/Tests
Proposed resolution
Let's move it there, but keep the old one as alias.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#16 | interdiff.txt | 22.05 KB | kmoll |
#16 | move-trait-2795045-16.patch | 26.52 KB | kmoll |
#8 | interdiff-279045-6-8.txt | 3.12 KB | legovaer |
#8 | move-trait-2795045-8.patch | 3.05 KB | legovaer |
Comments
Comment #2
dawehnerComment #3
dawehnerComment #4
legovaer@dawehner,
I've been looking into this issue. But we're using this Trait in about 73 different places. What do you exactly mean with "let's keep the old one as an alias"? Should we copy the existing trait to the new location and keep the old file in the place where it now is? This will introduce code duplication, right?
Comment #5
tim.plunkettComment #6
legovaerThanks for the help #5!
Comment #8
legovaerUsed the example of #5 a bit too literally.
Comment #9
dawehnerComment #10
dawehnerNice, so this is really just a move!
Comment #12
legovaerWhat? How & why?
Comment #13
dawehnerSometimes there is some hidden reason. Its certainly not your fault :)
Comment #14
alexpottThe original trait needs a deprecation notice and we should update core usages here too.
Comment #15
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedComment #16
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedI have added the deprecated message and updated all core usages to use the new namespace.
Comment #17
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedComment #18
kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commentedComment #19
Robin Monks CreditAttribution: Robin Monks at Appnovation commentedApplied this match and ran all PHPUnit tests locally (which technically is just doing my human hands what testbot already did), and can confirm it works.
Comment #20
catchCommitted/pushed to 8.3.x, thanks!