Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In DBTNG Example module there is no example for "Group By" query as mentioned in #718672-1: DBTNG Example needs more examples
Comment | File | Size | Author |
---|---|---|---|
#29 | dbtng_example_needs-2791397-25.patch | 4 KB | arijits.drush |
| |||
#27 | interdiff_21_24.txt | 8.08 KB | Mile23 |
#24 | Screen Shot 2017-01-16 at 1.31.49 PM.png | 65.33 KB | Manav |
#24 | dbtng_example_needs-2791397-24.patch | 9.58 KB | Manav |
| |||
#21 | dbtng_example_needs-2791397-16.patch | 3.98 KB | arijits.drush |
|
Comments
Comment #2
minakshiPh CreditAttribution: minakshiPh at Iksula commentedKindly review the attached patch for "Group By" example.
Thanks!
Comment #3
minakshiPh CreditAttribution: minakshiPh at Iksula commentedComment #4
minakshiPh CreditAttribution: minakshiPh at Iksula commentedComment #5
minakshiPh CreditAttribution: minakshiPh at Iksula commentedModified the patch with some corrections
Kindly review
Thanks!
Comment #6
minakshiPh CreditAttribution: minakshiPh at Iksula commentedcorrected the previous patch and interdiff
Kindly review
Thanks!
Comment #10
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedComment #11
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedHi @minakshi
I have found some issue in your patch. If your are using "groupBy" clause then use aggregate function with it. "The GROUP BY statement is used in conjunction with the aggregate functions to group the result-set by one or more columns." check this link: groupBy.
Attaching modified patch for the same.
Comment #12
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedComment #14
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedI have checked CI error log and found the problem that "Parse error: syntax error, unexpected '[' in /var/www/html/sites/all/modules/examples/dbtng_example/dbtng_example.module on line 634".
Attaching patch again to remove this error.
Comment #15
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedComment #16
JayKandari#14 Looks Good. Changing to RTBC.
Comment #17
Mile23Needs a test which logs in a user with the permissions and then tries to visit that path. Just add it to
DBTNGExampleUnitTestCase::testUI()
.Comment #18
Mile23Comment #19
arijits.drushComment #20
SwapS CreditAttribution: SwapS as a volunteer commentedReview comments on patch #19
1) Would be good to use appropriate test user name
2) Also , No need of Access argument here . Isnt solving any purpose here.
Cheers
SwapS
Comment #21
arijits.drushComment #22
SwapS CreditAttribution: SwapS as a volunteer commentedThis looks good to me now.
Good for merge
Cheers
SwapS
Comment #23
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedComment #24
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedI have checked this patch. Everything thing is fine but there is some coding standard issue so attaching patch again. Also attaching screen-shot for last updated patch, which showing the test result against this patch.
Comment #25
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedThanks arijits.drush and SwapS for this test cases.
Comment #26
Mile23Thanks for the screenshot, but we get a pass/fail from the testbot.
Also, an interdiff would be very helpful for review. Saves a lot of time and effort: https://www.drupal.org/documentation/git/interdiff
Attached is an interdiff for #24. It's all out of scope, meaning it doesn't fix the issue we're working on. If you'd like to fix CS errors in this module, please file another issue.
Reviewing #21:
These lines use tabs instead of spaces, so they're indented incorrectly.
Once we get that done, we're pretty close. :-)
Comment #27
Mile23Ewps... Interdiff.
Comment #28
arijits.drushComment #29
arijits.drushComment #30
arijits.drushComment #31
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedPatch #29 working fine for me.
Comment #32
Manav CreditAttribution: Manav as a volunteer and at QED42 commentedComment #34
valthebaldCommitted and pushed to 7.x-1.x. Thanks everyone!