Don't append 'js-quickedit-page-title' class when user doesn't have 'access in-place editing' permission

I confirm the problem and that the patch solves it without creating problem when the user has permission for in-place editing.

I attach screenshots before (both with and without in-place editing permission) and after

Given the preprocess is currently a one-liner, let's avoid the negative condition and early return, and add the class inside the if instead.

Here is the patch according to #4

Lucky permissions are a permanent cache context otherwise this sort of variability in a template is tricky. How given this is a condition on a permission we should test it.

We can easily add two simple assertions to \Drupal\quickedit\Tests\QuickEditLoadingTest::testUserWithoutPermission() and \Drupal\quickedit\Tests\QuickEditLoadingTest::testUserWithPermission().

OK. Go with tests!

Oh sorry! Now with correct xpath.

Test fail, fix pass.

+    $this->assertNoFieldByXPath('//h1[contains(@class, "js-quickedit-page-title")]', NULL, 'in-place js-quickedit-page-title editing class does not exists');

Point at the end of the sentence, can be fixed on commit.

This is a sister issue of #2528498: Only emit Quick Edit data- attributes when actually necessary.

Tests have been added.

1. +++ b/core/modules/quickedit/quickedit.module
   @@ -117,7 +117,9 @@ function quickedit_field_formatter_info_alter(&$info) {
   -  $variables['title_attributes']['class'][] = 'js-quickedit-page-title';
   +  if (\Drupal::currentUser()->hasPermission('access in-place editing')) {
   +    $variables['title_attributes']['class'][] = 'js-quickedit-page-title';
   +  }
   

   This is missing a cache context. See the patch at #2528498-23: Only emit Quick Edit data- attributes when actually necessary.

2. +++ b/core/modules/quickedit/src/Tests/QuickEditLoadingTest.php
   @@ -108,6 +108,9 @@ public function testUserWithoutPermission() {
   +    // Check that does not exist in-place editing title class.
   

   This sentence does not make sense. Let's use the same sentence as #2528498-23: Only emit Quick Edit data- attributes when actually necessary uses.

3. +++ b/core/modules/quickedit/src/Tests/QuickEditLoadingTest.php
   @@ -108,6 +108,9 @@ public function testUserWithoutPermission() {
   +    $this->assertNoFieldByXPath('//h1[contains(@class, "js-quickedit-page-title")]', NULL, 'in-place js-quickedit-page-title editing class does not exists');
   
   @@ -161,6 +164,9 @@ public function testUserWithPermission() {
   +    $this->assertFieldByXPath('//h1[contains(@class, "js-quickedit-page-title")]', NULL, 'in-place editing js-quickedit-page-title class exists.');
   

   Let's omit the messages here, because they don't make a lot of sense (and adding such messages doesn't add much value anyway).

4. +++ b/core/modules/quickedit/src/Tests/QuickEditLoadingTest.php
   @@ -161,6 +164,9 @@ public function testUserWithPermission() {
   +    // Check for in-place editing title class.
   

   Let's use the same sentence as #2528498-23: Only emit Quick Edit data- attributes when actually necessary uses.

Maybe we can merge two comments in one? :)

Go again.

Committed 10210c7 and pushed to 8.3.x. Thanks!