When I go through the new install wizard (congratulations on that) it tells me, at the last step:

Provision has not imported any sites yet. You may wait a few moments and reload this page, or click on the button to complete your installation.

I *think* it's because the sites/default directory is being ignored by the import process.

Comments

adrian’s picture

adrian CreditAttribution: adrian commented

It's the fact that the verify step creates the import step. so it takes another minute before it can run.

anarcat’s picture

anarcat CreditAttribution: anarcat commented

No, that's not the issue here: the import step never gets created, the site never gets created, however long I wait. See hostmaster.koumbit.net for an example.

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Priority: Normal » Critical

This should be working for the first release.

anarcat’s picture

anarcat CreditAttribution: anarcat commented

Actually, the issue here is that it's not working when you use the sites/default folder (which is the default behavior).

It should be either documented that "you shouldn't do that" or that we find another way...

anarcat’s picture

anarcat CreditAttribution: anarcat commented

So the consensus here is that we should flag "sites/default/settings.php" as an error in the verify hook.

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Title: main hostmaster install not imported as a site » warn the user about ignore sites/default/settings.php
Category: bug » feature

We can't really know what the settings.php is for if it's in sites/default/settings.php in the platform verify. So we just skip it now. We should flag such files as errors and request the user to move them in a proper location so we can create the site.

Eventually, we could do this ourselves through the verification script, by first prompting the user for the site(s) that are relevant to that settings.php, but for now we'll go the easy way.

adrian’s picture

adrian CreditAttribution: adrian commented

The issue is it needs to load all the code for each of the drupal installs.

Since there's no namespace support, it will crash if you try to load the needed code for 2 drupal trees.

Additionally, the internal code we call for installs change between releases. We could do a lot more if we break our patching core rule, but i don't think we should

adrian’s picture

adrian CreditAttribution: adrian commented

Fixed as part of #319389.

There is now a warning in the verify step that it does not support 'default' directories.

adrian’s picture

adrian CreditAttribution: adrian commented
Status: Active » Needs review
adrian’s picture

adrian CreditAttribution: adrian commented

I added a requirement to install that forces the user to move the default directory to the URL sites directory before install can happen, but I've started thinking about forcing hostmaster / provision sites to be installed in default. Which does away with the issue we had before, and we disable install.php and it makes the definition of platform clearer.

We can also drop the uri argument from all crush calls, and provide a 'site not found' or site error page.

adrian’s picture

adrian CreditAttribution: adrian commented
Status: Needs review » Fixed

Committed to HEAD

adrian’s picture

adrian CreditAttribution: adrian commented

Expanded on the last comment on #321940. Forcing install in sites/default is a very small change.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.