Follow-up to #2779939: Cleanup the ModerationInformationInterface

Problem/Motivation

ModerationInformationInterface should have nothing to do with forms

Proposed resolution

Remove isModeratedEntityForm and isRevisionableBundleForm

Remaining tasks

User interface changes

None

API changes

Removals:

  • Remove ModerationInformationInterface::isRevisionableBundleForm() it is unnecessary and removed
  • Remove ModerationInformationInterface::isModeratedEntityForm() it is unnecessary and removed

Data model changes

None

CommentFileSizeAuthor
#7 2784341-7.patch9.18 KBalexpott
#4 2784341-4.patch9.21 KBalexpott
#4 3-4-interdiff.txt2.15 KBalexpott
#3 2784341-3.patch7.06 KBalexpott
#3 2-3-interdiff.txt1.81 KBalexpott
#2 2784341-2.patch5.25 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2784341-2.patch5.25 KB

The calls to the moderation information methods will need fixing if #2779939: Cleanup the ModerationInformationInterface lands.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2-3-interdiff.txt1.81 KB
2784341-3.patch7.06 KB

Oops forgot to the remove the methods... and the fact these can be refactored without altering tests shows that these methods have little business being on a public service.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
3-4-interdiff.txt2.15 KB
2784341-4.patch9.21 KB

Well there were unit tests of the service... lol. Still no point these methods being on a service they are tightly bound to the hook implementation.

The last submitted patch, 3: 2784341-3.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Think we're good to go!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2784341-7.patch9.18 KB

Rerolled because #2779939: Cleanup the ModerationInformationInterface landed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Title: Remove form functions from ModerationInterface » Remove form functions from ModerationInformationInterface

  • catch committed 04abf4c on 8.2.x 
    Issue #2784341 by alexpott: Remove form functions from...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

  • alexpott committed 3c1ce58 on 8.3.x authored by catch 
    Issue #2784341 by alexpott: Remove form functions from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.