This methods returns array of results but declares a single result

Also $children protected property is not documented

CommentFileSizeAuthor
#2 result-interface.patch849 bytesandypost
result-interface.patch849 bytesandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
result-interface.patch849 bytes

Status: Needs review » Needs work

The last submitted patch, 2: result-interface.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: result-interface.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: result-interface.patch, failed testing.

The last submitted patch, 2: result-interface.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Reviewed & tested by the community

back to rtbc

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: result-interface.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Reviewed & tested by the community

Looks tests was not fixed

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented

That's probably because the testbot checks out the alpha-16 version and not the -dev version that includes the fix. I'll run tests locally to see if that's the case.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Yep, This is a docs-only patch so I just wanna check after #2777483: Unmet dependencies

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

  • borisson_ committed 052403e on 8.x-1.x authored by andypost 
    Issue #2783859 by andypost: Return value of ResultInterface::getChildren...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.