API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...
The description for #markup contains the following sentence. (Emphasis is mine.)
Aternatively, you can use the render array key #allowed_tags to alter which tags are filtered.
It should be Alternatively.
Also, let's fix this sentence. (I added the <code>
tags for showing the code here.)
(I.e,
<script>
and<style>
are not allowed.)
I.e should eventually be I.e., but I would rather use For example, since the list of filtered tags is probably not exhaustive.
(For example,
@code <script> @endcode
and@code <style> @endcode
are not allowed.)
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff.txt | 1.13 KB | pguillard |
#18 | improve-documentation-2781927-18.patch | 3.82 KB | pguillard |
#13 | improve-documentation-2781927-13.patch | 3.57 KB | Eda |
#11 | improve-documentation-2781927-11.patch | 3.54 KB | apaderno |
#9 | fix-a-typo-2781927-9.patch | 1.48 KB | apaderno |
Comments
Comment #2
apadernoComment #3
cilefen CreditAttribution: cilefen commentedComment #4
pguillard CreditAttribution: pguillard commentedBoth typos fixed. For the second one, we had #2637336: Replace i.e. and e.g. with English words in /core/includes and /core/misc directory, still in standby
Comment #5
pguillard CreditAttribution: pguillard commentedOops, I guess we posted same response at the same time..
Comment #7
apadernoComment #8
apadernoComment #9
apadernoI have also fixed a too verbose sentence, other than fixing a line overflow in my previous patch. The previous one also fixed a missing indeterminate article.
Comment #10
apadernoAlso, since in Drupal 8 there are just theme hooks using template files, this phrase can be shortened to "implement a theme hook and/or an asset library."
Comment #11
apadernoLet's make it more generic, since there isn't just a typo to correct; there is also the punctuation to correct, and some sentences to make more coincise. Also, the example shows how to allow a tag that is already whitelisted; it should show how to allow a tag that is otherwise filtered out.
Comment #12
Eda CreditAttribution: Eda commented+ * type of "render element" (for example 'form', for an HTML form; 'textfield',
Needs a comma after "(for example...", like:
* type of "render element" (for example, 'form', for an HTML form; 'textfield',
Comment #13
Eda CreditAttribution: Eda commentedFix the comma and remove the word "three" as there were more properties listed, not 3.
Comment #14
arunkumarkThe patch #13 is working fine.
Comment #16
pguillard CreditAttribution: pguillard commentedComment #17
kiwimind CreditAttribution: kiwimind at Investis Digital commentedLine length exceeds 80 characters.
Comment #18
pguillard CreditAttribution: pguillard commentedCorrected, thanks
Comment #19
kiwimind CreditAttribution: kiwimind at Investis Digital commentedComment #20
kiwimind CreditAttribution: kiwimind at Investis Digital commentedCool, passed, in which case, all looks good so have a RTBC.
Comment #21
alexpottThis is an improvement and nothing is wrong with any of the changes. Also as a docs fix this can be backported to 8.2.x.
Committed and pushed aa03660 to 8.3.x and 1656c67 to 8.2.x. Thanks!