Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think Tim said this is actually a Bartik issue.
However, this looks rather assy. :P
Environment details to reproduce the issue :
Chrome Version 52.0.2743.116 (64-bit)
Mac OsX
Comment | File | Size | Author |
---|---|---|---|
#39 | 2781579-39.patch | 485 bytes | tedbow |
#34 | Drupal-8-firefox.png | 21.57 KB | Vidushi Mehta |
#34 | drupal-8-chrome.jpeg | 40.27 KB | Vidushi Mehta |
#33 | 2781579-33.patch | 483 bytes | amit.mall |
#30 | 2781579.jpg | 65.31 KB | amit.mall |
Comments
Comment #2
webchickComment #3
Manjit.SinghComment #4
Manjit.SinghLooks like this issue is exist only for mac users, I have checked it in Linux-Ubuntu, It looks good to me. Buttons are not overlapping with the scrollbar.
Comment #5
naveenvalechaThis does not seems to be the OS specific rather than browser version specific.
I'm able to reproduce it.
Adding screenshot with the environment detail.
Comment #6
Manjit.SinghI am not able to see the screenshot @Naveen. Seems like it has nothing.
Comment #7
Gábor Hojtsy@naveenvalecha: yeah it has a dot and a red dashed square, hard to tell what you mean by that
Comment #8
naveenvalechaSorry for the wrong snapshot. Seems the Awesome Screenshot chrome extension was not happy that time :P
I investigated the problem more in depth, the problem is not macspecific. its due to the resolution of the screen.See in the screenshots below.I'll dig further with Manjit tomorrow in person.
Comment #9
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedI have attached patch for the above issue with screenshot. Please review.
Comment #10
Manjit.SinghSeems like text is still overlapping and not visible properly. see the screenshots.
Comment #11
nathanlawsn CreditAttribution: nathanlawsn commentedSeems that there is insufficient space when the row weights are visible.
If you remove the 120px minimum width from the first column and set the table row & column width to 100% it has sufficient space.
Don't suppose you know why we have a minimum width?
Comment #13
brahmjeet789 CreditAttribution: brahmjeet789 as a volunteer and at gai Technologies Pvt Ltd commentedComment #14
brahmjeet789 CreditAttribution: brahmjeet789 as a volunteer and at gai Technologies Pvt Ltd commentedplease review the patch
Comment #15
brahmjeet789 CreditAttribution: brahmjeet789 as a volunteer and at gai Technologies Pvt Ltd commentedComment #16
moonpeak CreditAttribution: moonpeak at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedHi,
Could you specify the steps to reproduce the issue. I downloaded and applied the patch on my local instance but, was unable to see menu under block layout.
Comment #17
nathanlawsn CreditAttribution: nathanlawsn commented@moonpeak Have you enabled the Settings Tray module?
If so, hit 'Quick Edit' on the Tools block.
Comment #18
Manjit.SinghThis need bit more testing with the latest patch. @moonpeak It would be good if you can do that.
Comment #19
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedAdded new patch for this with before and after screenshots. @Manjit please look into this.
Comment #20
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedThis is the updated patch. Please review this.
Comment #21
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedComment #22
Gábor Hojtsy@Vidushi Mehta: why is this better/different, what did you find with the previous one, how is this fixing it better?
Comment #23
Manjit.Singh@Vidushi: Seems like #19 & #20 have completely different from each other. Seems like, there some mistake while creating the patch file. Can you please look into this. And Please don't forget to attach interdiff file in future.
Comment #24
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commented@Gabor and @Manjit sorry actually by mistake i had uploaded my old patch that is #19 but the new and correct one is #20 and the screenshots that i had attached with #19 are for the patch #20.
So please ignore #19 patch and review #20.
Comment #25
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedComment #26
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #27
tkoleary CreditAttribution: tkoleary at Acquia commentedOther changes have resolved this issue by introducing better sandboxing of tray css.
Comment #28
tkoleary CreditAttribution: tkoleary at Acquia commentedNo, I spoke too soon. The problem at #10 still exists, but the patch at #20 does not properly resolve it.
What is needed is a way to make the table 100% but for it to 'flex' when the extra scroll bar appears.
Comment #29
amit.mall CreditAttribution: amit.mall at TO THE NEW commentedI have fixed text "Operations" overlapping issue and it's working fine. I have attached patch for this please review.
Comment #30
amit.mall CreditAttribution: amit.mall at TO THE NEW commentedComment #31
tkoleary CreditAttribution: tkoleary at Acquia commentedLooks great!
Comment #32
xjmThanks @amit.mall!
Doesn't this just permanently reduce the width, though? Is there a particular reason 85px is being chosen?
Also, there's this CSS just above:
Comment #33
amit.mall CreditAttribution: amit.mall at TO THE NEW commented@xjm #32, I found 85px is minimum width to occupy left side content, but since there is a css property- white-space: nowrap; so no need to have min-width, I have removed this in new attached patch, result is same
Comment #34
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedI reviewed patch #33. Looks fine for me.
Attaching screenshots for the same after applying the patch.
Comment #35
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #36
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #37
webchickNeeds a re-roll after one of the ones that was committed today.
Comment #38
webchickIn the meantime, adding credit.
Comment #39
tedbowJust a re-roll
Comment #40
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #42
webchickCommitted and pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!
Comment #47
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)