The dropbutton on /admin/structure/types currently has all the tabs apart from "Manage moderation".

CommentFileSizeAuthor
#4 interdiff.txt936 bytestimmillwood
#4 add_manage_moderation-2780705-4.patch1.56 KBtimmillwood
#2 add_manage_moderation-2780705-2.patch664 bytestimmillwood
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Title: Add "Manage moderation" to dropbutton on /admin/structure/types » Fix "Manage moderation" dropbutton on /admin/structure/types
Status: Active » Needs review
FileSize
add_manage_moderation-2780705-2.patch664 bytes

It was already there, just broken.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Needs work
Issue tags: +Needs tests
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
add_manage_moderation-2780705-4.patch1.56 KB
interdiff.txt936 bytes

Adding tests

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Version: 8.3.x-dev » 8.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed ffe7d13ab1ad8dc32c92dbe98a914d93ad3f1462 to 8.3.x and d544c7c to 8.2.x. Thanks!

Oops I probably broke this - nice to have a test.

  • alexpott committed ffe7d13 on 8.3.x 
    Issue #2780705 by timmillwood: Fix "Manage moderation" dropbutton on /...

  • alexpott committed d544c7c on 8.2.x 
    Issue #2780705 by timmillwood: Fix "Manage moderation" dropbutton on /...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.