Problem/Motivation

As a goat, I want only the goatherders who can update the entity have access to the path admin/config/content/mollom/report/{entity_type}/{entity}. According to the EntityAccessCheck doxygen, the value of _entity_access needs to include the entity type which is of course impossible because it is dynamic.

Proposed resolution

Surprise! This already works, the doc comment is actually wrong. Behold the entity type called 'entity'.

Remaining tasks

Document it. No code changes are necessary because testAccessWithTypePlaceholder even tests this, unless I misunderstood something which of course is not hard since I am just a goat.

CommentFileSizeAuthor
#5 Selection_318.png121.53 KBchx
#4 2778809_3.patch1.31 KBchx
#2 2778809_2.patch1.34 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx created an issue. See original summary.

chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Title: EntityAccessCheck is actually usable but you'd never tell that from the class doxygen » _entity_access is actually usable but you'd never tell that from the class doxygen
Status: Active » Needs review
FileSize
2778809_2.patch1.34 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2778809_2.patch, failed testing.

chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Status: Needs work » Needs review
FileSize
2778809_3.patch1.31 KB
chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Issue summary: View changes
FileSize
Selection_318.png121.53 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

This is improving the documentation on a good way!

chx’s picture

chx CreditAttribution: chx at Smartsheet commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to all three 8.x branches, thanks!

  • catch committed 03f46ef on 8.3.x 
    Issue #2778809 by chx: _entity_access is actually usable but you'd never...

  • catch committed 6aa5c07 on 8.2.x 
    Issue #2778809 by chx: _entity_access is actually usable but you'd never...

  • catch committed f121119 on 8.1.x 
    Issue #2778809 by chx: _entity_access is actually usable but you'd never...
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.