Problem/Motivation

Follow-up to #2225775: Migrate Drupal 6 core node translation to Drupal 8.

Uploads need to be provide the langcode so that they can be assigned to the right language.

Means that the upload fields need to be marked translatable I suppose if that's not the case yet.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#15 2768823-15.patch6.08 KBjofitz
#12 2768823-12-complete.patch6.11 KBjofitz
#12 2768823-12-test_only.patch4.73 KBjofitz
#11 2768823-11.patch1.38 KBjofitz
#7 2768823-7.patch1.38 KBjofitz
#7 interdiff-2-7.txt491 bytesjofitz
#2 d6-upload-language-2768823-2.patch1.31 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
d6-upload-language-2768823-2.patch1.31 KB

Not sure if this is going to work.

Status: Needs review » Needs work

The last submitted patch, 2: d6-upload-language-2768823-2.patch, failed testing.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Issue tags: +migrate-d6-d8
jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
FileSize
interdiff-2-7.txt491 bytes
2768823-7.patch1.38 KB

Now able to handle nodes without langcode.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Issue tags: +i18n-migrate
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Certainly needs tests and a migration for the upload multilingual variables.

There are no translations for those variables in the d6_dump, so they need to be added. Using the UI they can be added at admin/settings/uploads. And to view the existing variable translations goto admin/settings/language/i18n/variables.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
FileSize
2768823-11.patch1.38 KB

Patch in #7 no longer applies. Re-rolled.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Issue tags: -Needs tests
FileSize
2768823-12-test_only.patch4.73 KB
2768823-12-complete.patch6.11 KB

Added tests. No interdiff, because the only changes are in the test_only patch.

The last submitted patch, 12: 2768823-12-test_only.patch, failed testing. View results

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch no longer applies against 8.5.x.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2768823-15.patch6.08 KB

Re-rolled for 8.5.x.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

maxocub’s picture

maxocub CreditAttribution: maxocub as a volunteer commented
Status: Needs review » Reviewed & tested by the community

This looks good, thank you @Jo Fitzgerald!

  • catch committed c470f14 on 8.6.x 
    Issue #2768823 by Jo Fitzgerald, Berdir, quietone: Store uploads in...

  • catch committed 5a48c60 on 8.5.x 
    Issue #2768823 by Jo Fitzgerald, Berdir, quietone: Store uploads in...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.