Tests needed: contact - updating site wide category

1) Navigating to /contact or via the contact menu item (after enabling it) without setting up a category presents an error message "The contact form has not been configured. Add one or more categories to the form", which correctly provides a link directly to the settings page to add a contact form category.

2) When adding a contact form category the form correctly requires a valid email-formatted recipient.

Not sure if it's intended, but the contact form settings page doesn't have the same drag-and-drop prioritising that modules such as blocks and taxonomy have. It would be good to have it for consistency.

oh, then please disregard my other posts...

#1 and #2 are dead code - both those fields are '#required' => TRUE which means they never get to validation, so that can never be run.

So this patch adds a test to ensure the requirement is set (so covers the behaviour for #1 and #2), and removes the redundant validation code for empty fields. That'll mean it gets caught if someone tries to removed the '#required' => TRUE later on. Doesn't touch #3 at all.

contact.test has four known failures #253506 which are unaffected by this patch.

Nice side effect of the code coverage reports :)

+    $this->addCategory($category = '', '', '', TRUE);

I'm not so sure this is gonna work

dmitrig01, it's not supposed to. Or did you mean something else?

I think this patch looks good. Committed to CVS HEAD.

Thanks.

We're still missing #3, so markin back to active for that one.

This is my first patch.
Is it enough to test for the text "Category %category has been added." or should i take every filed and test if it has been updated ?

cwgordon7, thanks for suggestion. I think now the coding standards should be fine. I also added db category updates check.
Have a look.

Back from vacation -- see http://buytaert.net/houffalize. Committed to CVS HEAD. Will be working the patch queue the next couple of days.