Not really a typo, just one region was mentioned twice,
/core/themes/classy/templates/layout/page.html.twig
* Regions:
* - page.header: Items for the header region.
* - page.highlighted: Items for the highlighted region.
* - page.primary_menu: Items for the primary menu region.
* - page.secondary_menu: Items for the secondary menu region.
* - page.highlighted: Items for the highlighted content region.
* - page.help: Dynamic help text, mostly for admin pages.
* - page.content: The main content of the current page.
* - page.sidebar_first: Items for the first sidebar.
* - page.sidebar_second: Items for the second sidebar.
* - page.footer: Items for the footer region.
* - page.breadcrumb: Items for the breadcrumb region.
Same typo was found in all available releases: 8.1.3, 8.1.x-dev and 8.2.x-dev
Comment | File | Size | Author |
---|---|---|---|
#5 | typo_in_comments_classy_theme-2760585-5.patch | 592 bytes | Ramdas Gaikar |
Comments
Comment #2
Ramdas Gaikar CreditAttribution: Ramdas Gaikar at Intelliswift commentedComment #3
Ramdas Gaikar CreditAttribution: Ramdas Gaikar at Intelliswift commentedHi tulvit,
Please check the below patch. It removes the duplicate region comment.
Comment #4
cilefen CreditAttribution: cilefen commentedGood, but let us keep the second one, "page.highlighted: Items for the highlighted content region." instead because that is what the system template reads.
Comment #5
Ramdas Gaikar CreditAttribution: Ramdas Gaikar at Intelliswift commentedDone changes as mentioned in #4.
Comment #6
cilefen CreditAttribution: cilefen commentedComment #9
star-szrCommitted and pushed 46efe01 to 8.2.x and ef415cf to 8.1.x. Thanks!